Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Separate internal application files from project structure #873

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 25, 2023

About

This PR is seperating files supporting the underlying Laravel (Zero) application from the actual project structure. This PR is breaking. The idea behind these changes is to put things that the user usually does not need to edit out of the way so they can focus on what actually matters. Resolves #874

Major Changes

Additional changes

  • Break out application logo from the app config 99f177a
  • Use a more graceful method for re-enabling package auto-discovery 32b483a

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #873 (872a864) into master (dcf0266) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 872a864 differs from pull request most recent head 940098d. Consider uploading reports for the commit 940098d to get more accurate results

@@              Coverage Diff              @@
##              master      #873     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1264      2542   +1278     
=============================================
  Files            150       302    +152     
  Lines           3332      6734   +3402     
=============================================
+ Hits            3332      6734   +3402     
Impacted Files Coverage Δ
...ramework/src/Console/Commands/BuildSiteCommand.php 100.00% <100.00%> (ø)
...rk/src/Console/Commands/PackageDiscoverCommand.php 100.00% <100.00%> (ø)
...ork/src/Console/Commands/PublishConfigsCommand.php 100.00% <100.00%> (ø)
...s/framework/src/Console/ConsoleServiceProvider.php 100.00% <100.00%> (ø)
packages/framework/src/Facades/Features.php 100.00% <100.00%> (ø)
packages/framework/src/Facades/Site.php 100.00% <100.00%> (ø)
packages/framework/src/Foundation/Application.php 100.00% <100.00%> (ø)
...ackages/framework/src/Foundation/ConsoleKernel.php 100.00% <100.00%> (ø)
...work/src/Foundation/Internal/LoadConfiguration.php 100.00% <100.00%> (ø)
...ges/framework/src/Foundation/Kernel/Hyperlinks.php 100.00% <100.00%> (ø)
... and 158 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

caendesilva and others added 7 commits January 25, 2023 21:38
Laravel Zero disables auto-discovery, but we want to use it, so we'll call the grandparent's method instead of the parent's, instead of the previous behaviour where Laravel enables it, Zero disables it, and we disable it again. What this change does is letting Laravel handle it, but with our custom cache path.
…ure-' of github.com:hydephp/develop into separate-internal-application-files-from-project-structure-
@caendesilva
Copy link
Member Author

See if we can move config/app.php to app/config.php

…s-to-allow-specification-of-which-group-to-publish

Add more config publishable options so categorized tags can be selected
@caendesilva caendesilva temporarily deployed to pr-documentation-873 February 12, 2023 14:14 — with GitHub Actions Inactive
github-actions bot pushed a commit that referenced this pull request Feb 12, 2023
@caendesilva caendesilva temporarily deployed to pr-documentation-873 February 12, 2023 14:24 — with GitHub Actions Inactive
github-actions bot pushed a commit that referenced this pull request Feb 12, 2023
@caendesilva caendesilva temporarily deployed to pr-documentation-873 February 12, 2023 14:43 — with GitHub Actions Inactive
github-actions bot pushed a commit that referenced this pull request Feb 12, 2023
@caendesilva caendesilva marked this pull request as ready for review February 12, 2023 15:13
@caendesilva caendesilva temporarily deployed to pr-documentation-873 February 12, 2023 15:13 — with GitHub Actions Inactive
github-actions bot pushed a commit that referenced this pull request Feb 12, 2023
@caendesilva caendesilva changed the title Separate internal application files from project structure Breaking: Separate internal application files from project structure Feb 12, 2023
github-actions bot pushed a commit that referenced this pull request Feb 12, 2023
@caendesilva caendesilva merged commit 963312a into master Feb 12, 2023
@caendesilva caendesilva deleted the separate-internal-application-files-from-project-structure- branch February 12, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

See if we can move config/app.php to app/config.php
2 participants