Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more publishable options for configs so specific tags can be selected #983

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Feb 12, 2023

Adds two new publishable groups, one for Hyde configs, and one for support configs.

Fixes the following code review comment:

Split out publishable key vendor config files? Maybe vendor-configs? It's a bit weird now that when you run the update:config commands new (the removed) files get added. Might be better to have a --no-vendor or --include-vendor option. #873

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #983 (00a6fd0) into separate-internal-application-files-from-project-structure- (6adeb17) will not change coverage.
The diff coverage is n/a.

@@                                        Coverage Diff                                        @@
##             separate-internal-application-files-from-project-structure-      #983     +/-   ##
=================================================================================================
  Coverage                                                         100.00%   100.00%             
+ Complexity                                                          2540      1270   -1270     
=================================================================================================
  Files                                                                302       151    -151     
  Lines                                                               6692      3357   -3335     
=================================================================================================
- Hits                                                                6692      3357   -3335     
Impacted Files Coverage Δ
...ndation/Providers/ConfigurationServiceProvider.php 100.00% <0.00%> (ø)
...ndation/Providers/ConfigurationServiceProvider.php
...mework/src/Foundation/Concerns/ManagesViewData.php
packages/framework/src/Foundation/HydeKernel.php
...work/Concerns/Internal/SetsUpMarkdownConverter.php
...ork/src/Framework/Concerns/TracksExecutionTime.php
...mework/Features/XmlGenerators/SitemapGenerator.php
...ages/framework/src/Markdown/Models/FrontMatter.php
packages/framework/src/Facades/Meta.php
packages/framework/src/Support/Models/RouteKey.php
... and 142 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review February 12, 2023 14:13
@caendesilva caendesilva changed the title Add more config publishable options so categorized tags can be selected Add more publishable options for configs so categorized tags can be selected Feb 12, 2023
@caendesilva caendesilva changed the title Add more publishable options for configs so categorized tags can be selected Add more publishable options for configs so specific tags can be selected Feb 12, 2023
@caendesilva caendesilva merged commit 437ccbd into separate-internal-application-files-from-project-structure- Feb 12, 2023
@caendesilva caendesilva deleted the update-publishable-config-choices-to-allow-specification-of-which-group-to-publish branch February 12, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant