Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

See if we can move config/app.php to app/config.php #874

Closed
caendesilva opened this issue Jan 26, 2023 · 3 comments · Fixed by #873
Closed

See if we can move config/app.php to app/config.php #874

caendesilva opened this issue Jan 26, 2023 · 3 comments · Fixed by #873

Comments

@caendesilva
Copy link
Member

See if we can move config/app.php to app/config.php

Originally posted by @caendesilva in #873 (comment)
@caendesilva
Copy link
Member Author

The app config is hardcoded in LoadConfiguration.php, and would require us to create our own Console Kernel implementation. Not sure if it's worth it at this poing.

@caendesilva caendesilva closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2023
@caendesilva caendesilva mentioned this issue Jan 26, 2023
Merged
12 tasks
@caendesilva
Copy link
Member Author

Gonna give this another shot, making after creating a custom kernel I'll see if I can reduce the added complexity.

@caendesilva caendesilva mentioned this issue Jan 30, 2023
Merged
@caendesilva
Copy link
Member Author

Completed in #890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking: Separate internal application files from project structure hydephp/develop
1 participant
@caendesilva