Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache config file #872

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 25, 2023

There should be virtually no reason for this file to edited from within a HydePHP application as I don't see any case where a different cache store is needed since it's mainly used for caching Blade views and it makes no sense to use a database or similar for this.

We should instead attempt to merge the information here into the custom Application class, but provide the ability to load from a custom file if one is present.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #872 (ba03e8a) into separate-internal-application-files-from-project-structure- (ca64f6e) will not change coverage.
The diff coverage is n/a.

@@                                       Coverage Diff                                       @@
##             separate-internal-application-files-from-project-structure-      #872   +/-   ##
===============================================================================================
  Coverage                                                         100.00%   100.00%           
  Complexity                                                          1246      1246           
===============================================================================================
  Files                                                                146       146           
  Lines                                                               3252      3252           
===============================================================================================
  Hits                                                                3252      3252           
Impacted Files Coverage Δ
...ork/src/Markdown/Processing/ColoredBlockquotes.php
...uildTasks/PostBuildTasks/GenerateBuildManifest.php
packages/framework/src/Pages/HtmlPage.php
packages/framework/src/Foundation/Hyperlinks.php
.../framework/src/Support/Models/ValidationResult.php
...c/Framework/Actions/CreatesNewMarkdownPostFile.php
packages/framework/src/Pages/VirtualPage.php
...amework/src/Console/Concerns/AsksToRebuildSite.php
...kages/framework/src/Markdown/MarkdownConverter.php
packages/framework/src/Facades/Asset.php
... and 282 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 25, 2023 20:34
@caendesilva caendesilva merged commit 1826514 into separate-internal-application-files-from-project-structure- Jan 25, 2023
@caendesilva caendesilva deleted the remove-cache-config-file branch January 25, 2023 20:37
caendesilva added a commit that referenced this pull request Feb 2, 2023
caendesilva added a commit that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant