-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register vendor configuration files in bootstrapper instead of in provider #978
Merged
caendesilva
merged 11 commits into
separate-internal-application-files-from-project-structure-
from
register-vendorized-configuration-files-in-bootstrapper-class
Feb 12, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovider" This reverts commit dc72285.
12 tasks
Codecov Report
@@ Coverage Diff @@
## separate-internal-application-files-from-project-structure- #978 +/- ##
===============================================================================================
Coverage 100.00% 100.00%
- Complexity 1266 1270 +4
===============================================================================================
Files 151 151
Lines 3339 3346 +7
===============================================================================================
+ Hits 3339 3346 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caendesilva
merged commit Feb 12, 2023
3642688
into
separate-internal-application-files-from-project-structure-
caendesilva
deleted the
register-vendorized-configuration-files-in-bootstrapper-class
branch
February 12, 2023 10:21
caendesilva
changed the title
Register inlined configuration files in bootstrapper class
Register inlined configuration files in bootstrapper class instead of provider
Feb 12, 2023
caendesilva
changed the title
Register inlined configuration files in bootstrapper class instead of provider
Register hidden configuration files in bootstrapper class instead of provider
Feb 12, 2023
caendesilva
changed the title
Register hidden configuration files in bootstrapper class instead of provider
Register vendor configuration files in bootstrapper instead of provider
Feb 12, 2023
caendesilva
changed the title
Register vendor configuration files in bootstrapper instead of provider
Register vendor configuration files in bootstrapper instead of a provider
Feb 12, 2023
caendesilva
changed the title
Register vendor configuration files in bootstrapper instead of a provider
Register vendor configuration files in bootstrapper instead of in provider
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the removed config files like view and cache were moved to the vendor directory in #873, they then became dependent on a service provider registration. Since their registration order is not guaranteed, this PR refactors to merge those configuration files in the configuration loading bootstrapper.
See #873 (comment)
The PR also deprecates
ConfigurationServiceProvider.php
as it's so simplified that it can be merged into the HydeServiceProvider.