Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register vendor configuration files in bootstrapper instead of in provider #978

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Feb 12, 2023

Since the removed config files like view and cache were moved to the vendor directory in #873, they then became dependent on a service provider registration. Since their registration order is not guaranteed, this PR refactors to merge those configuration files in the configuration loading bootstrapper.

See #873 (comment)

The PR also deprecates ConfigurationServiceProvider.php as it's so simplified that it can be merged into the HydeServiceProvider.

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #978 (aaea400) into separate-internal-application-files-from-project-structure- (70392e2) will not change coverage.
The diff coverage is n/a.

@@                                       Coverage Diff                                       @@
##             separate-internal-application-files-from-project-structure-      #978   +/-   ##
===============================================================================================
  Coverage                                                         100.00%   100.00%           
- Complexity                                                          1266      1270    +4     
===============================================================================================
  Files                                                                151       151           
  Lines                                                               3339      3346    +7     
===============================================================================================
+ Hits                                                                3339      3346    +7     
Impacted Files Coverage Δ
...packages/framework/src/Pages/Concerns/HydePage.php 100.00% <0.00%> (ø)
...packages/framework/src/Pages/DocumentationPage.php 100.00% <0.00%> (ø)
...ackages/framework/src/Foundation/ConsoleKernel.php 100.00% <0.00%> (ø)
...es/framework/src/Framework/HydeServiceProvider.php 100.00% <0.00%> (ø)
...work/src/Foundation/Internal/LoadConfiguration.php 100.00% <0.00%> (ø)
...k/src/Foundation/Providers/ViewServiceProvider.php 100.00% <0.00%> (ø)
...ndation/Providers/ConfigurationServiceProvider.php 100.00% <0.00%> (ø)
...rc/Framework/Services/YamlConfigurationService.php
...amework/src/Console/HydeConsoleServiceProvider.php
...s/framework/src/Console/ConsoleServiceProvider.php 100.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 3642688 into separate-internal-application-files-from-project-structure- Feb 12, 2023
@caendesilva caendesilva deleted the register-vendorized-configuration-files-in-bootstrapper-class branch February 12, 2023 10:21
@caendesilva caendesilva changed the title Register inlined configuration files in bootstrapper class Register inlined configuration files in bootstrapper class instead of provider Feb 12, 2023
@caendesilva caendesilva changed the title Register inlined configuration files in bootstrapper class instead of provider Register hidden configuration files in bootstrapper class instead of provider Feb 12, 2023
@caendesilva caendesilva changed the title Register hidden configuration files in bootstrapper class instead of provider Register vendor configuration files in bootstrapper instead of provider Feb 12, 2023
@caendesilva caendesilva changed the title Register vendor configuration files in bootstrapper instead of provider Register vendor configuration files in bootstrapper instead of a provider Feb 12, 2023
@caendesilva caendesilva changed the title Register vendor configuration files in bootstrapper instead of a provider Register vendor configuration files in bootstrapper instead of in provider Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant