Move the torchlight.php config file to the Framework package internals #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file will usually not need to be edited as it's preconfigured, so it does not need to be bundled with the base project install. Having it in the framework package internals means we can still load the existing data, and users can publish the file if they need to modify it. Published config files should always take precedence.
12 tasks
Codecov Report
@@ Coverage Diff @@
## separate-internal-application-files-from-project-structure- #950 +/- ##
===============================================================================================
Coverage ? 100.00%
Complexity ? 1254
===============================================================================================
Files ? 150
Lines ? 3312
Branches ? 0
===============================================================================================
Hits ? 3312
Misses ? 0
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ure-' into move-torchlight-config-file
caendesilva
merged commit dde0706
into
separate-internal-application-files-from-project-structure-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file will usually not need to be edited as it's preconfigured, so it does not need to be bundled with the base project install. Having it in the framework package internals means we can still load the existing data, and users can publish the file if they need to modify it. Published config files should always take precedence.