Skip to content

Commit

Permalink
Swap out bootstrapper for our own
Browse files Browse the repository at this point in the history
  • Loading branch information
caendesilva committed Jan 26, 2023
1 parent c42cd50 commit 82df89f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/framework/src/Foundation/Internal/Kernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ class Kernel extends \Illuminate\Foundation\Console\Kernel
*/
protected function bootstrappers()
{
return $this->bootstrappers;
$array = array_combine(parent::bootstrappers(), parent::bootstrappers());
$array[\Illuminate\Foundation\Bootstrap\LoadConfiguration::class] = \Hyde\Foundation\Internal\LoadConfiguration::class;

return array_values($array);
}
}

1 comment on commit 82df89f

@caendesilva
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if the best way to do this is dynamically like this, or my overriding the actual property. This is dynamic and would handle new classes being added to the base class, but that means it could change without us knowing. Might be better to hard code and add a test that fails if the base is changed so we can update accordingly. This is if this change is even merged at all.

Please sign in to comment.