Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_universe_utils)!: rename from tier4_autoware_utils #7538

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 17, 2024

Description

  • find ./ -type f -exec sed -i -e 's/tier4_autoware_utils/autoware_universe_utils/g' {} \;
  • Renamed tier4_autoware_utils directory to autoware_universe_utils.

https://github.com/orgs/autowarefoundation/discussions/4881

We apologize for the trouble regarding autoware_ prefix support for Planning/Control and appreciate your cooperation.
Thanks to your help, we are almost done with the individual node support.

As a final step, we are going to create a PR with significant changes, and we would like to inform you of them.
By this PR, We will change as

  • tier4_autoware_utils to autoware_universe_utils
  • motion_utils to autoware_motion_utils

Although this PR contains many code changes, including a change to almost all nodes in planning/control, we plan to merge the change by a single PR for simplicity and to avoid conflicts and work-in-progress problems.
We will proceed with the utmost care so as not to bring any defects to the main branch, and we appreciate your understanding and cooperation.

Related PR:
autowarefoundation/autoware_tools#52

part of autowarefoundation/autoware#4569

Tests performed

clean build all pacakges and psim/lsim

image

image

evaluator
https://evaluation.tier4.jp/evaluation/reports/2fa4d6f6-6ea2-5678-be51-bc85601dc37e?project_id=prd_jt

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 17, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 17, 2024
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 17, 2024
@kosuke55 kosuke55 marked this pull request as ready for review June 17, 2024 17:00
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/autoware-universe-utils branch from 638ec35 to 63e6f84 Compare June 17, 2024 17:14
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 46.39640% with 238 lines in your changes missing coverage. Please review.

Project coverage is 28.37%. Comparing base (507e3f4) to head (63e6f84).
Report is 33 commits behind head on main.

Files Patch % Lines
...based_prediction/src/map_based_prediction_node.cpp 0.00% 37 Missing ⚠️
...autoware_autonomous_emergency_braking/src/node.cpp 0.00% 31 Missing ⚠️
..._checker/src/predicted_path_checker_node/utils.cpp 0.00% 18 Missing ⚠️
..._departure_checker_node/lane_departure_checker.cpp 0.00% 10 Missing ⚠️
...toware_map_based_prediction/src/path_generator.cpp 28.57% 10 Missing ⚠️
...ils/include/motion_utils/trajectory/trajectory.hpp 87.69% 6 Missing and 2 partials ⚠️
...nclude/tier4_planning_rviz_plugin/path/display.hpp 0.00% 5 Missing ⚠️
...rsuit/autoware_pure_pursuit_lateral_controller.cpp 0.00% 5 Missing ⚠️
..._path_checker_node/predicted_path_checker_node.cpp 0.00% 5 Missing ⚠️
...ed_object_validation/src/object_lanelet_filter.cpp 0.00% 5 Missing ⚠️
... and 51 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7538       +/-   ##
===========================================
+ Coverage   14.84%   28.37%   +13.53%     
===========================================
  Files        1999     1419      -580     
  Lines      139163   104737    -34426     
  Branches    43716    45338     +1622     
===========================================
+ Hits        20661    29723     +9062     
+ Misses      95731    66697    -29034     
+ Partials    22771     8317    -14454     
Flag Coverage Δ
differential 28.37% <46.39%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r
Copy link
Member

The change seems to be quite large. They seems to be just simple replacement of namespace, but have you tested with any PSim/LSim so that Autoware launches without an error?

@kosuke55
Copy link
Contributor

I have tested psim and lsim after clean build of all pacakges

image

image

@mitsudome-r mitsudome-r merged commit 7a3e6ed into autowarefoundation:main Jun 18, 2024
39 of 44 checks passed
@mitsudome-r mitsudome-r deleted the feat/autoware-universe-utils branch June 18, 2024 05:53
privvyledge pushed a commit to privvyledge/trajectory_loader that referenced this pull request Jun 22, 2024
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…owarefoundation#7538)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants