Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yabloc_pose_initializer): componentize yabloc_pose_initializer node #7506

Merged

Conversation

KYabuuchi
Copy link
Contributor

Description

Componentize the node in localization/yabloc_pose_initializer.

Also, log output is changed from "screen" to "both".

Tests performed

1. Confirmed that yabloc works as conventional in logging_simulator

ros2 launch autoware_launch logging_simulator.launch.xml \
    map_path:=$HOME/Maps/nishishinjuku \
    vehicle_model:=sample_vehicle \
    sensor_model:=awsim_sensor_kit \
    pose_source:=yabloc

2. Confirmed that terminating the nodes process will output logs to both the terminal and the launch.log.

( The glog is printed only when using rclcpp_component customized by tier4. )

Effects on system behavior

The system behavior does not change.

Interface changes

The interface does not change.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jun 17, 2024
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 17, 2024
@KYabuuchi KYabuuchi marked this pull request as ready for review June 17, 2024 08:34
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 14.83%. Comparing base (507e3f4) to head (22e7f17).
Report is 6 commits behind head on main.

Files Patch % Lines
...alizer/src/camera/camera_pose_initializer_core.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7506      +/-   ##
==========================================
- Coverage   14.84%   14.83%   -0.02%     
==========================================
  Files        1999     2002       +3     
  Lines      139163   139175      +12     
  Branches    43716    43737      +21     
==========================================
- Hits        20661    20647      -14     
- Misses      95731    95776      +45     
+ Partials    22771    22752      -19     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.84% <ø> (-0.01%) ⬇️ Carriedforward from 507e3f4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that yabloc works fine in your rosbag data, and the glog appears when the yabloc_pose_initializer it is terminated.

LGTM 👍

@KYabuuchi
Copy link
Contributor Author

It seems a very large PR will be merged, so I will merge after it to avoid trouble.

@KYabuuchi KYabuuchi merged commit 609df50 into autowarefoundation:main Jun 19, 2024
40 of 41 checks passed
@KYabuuchi KYabuuchi deleted the feat/glog_yabloc_pose_initializer branch June 19, 2024 00:29
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…ode (autowarefoundation#7506)

* change the node to component

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* remove useless node.cpp

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* add rclcpp_components as dependency

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

---------

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ode (#7506)

* change the node to component

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* remove useless node.cpp

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* add rclcpp_components as dependency

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

---------

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants