-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(yabloc_pose_initializer): componentize yabloc_pose_initializer node #7506
feat(yabloc_pose_initializer): componentize yabloc_pose_initializer node #7506
Conversation
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7506 +/- ##
==========================================
- Coverage 14.84% 14.83% -0.02%
==========================================
Files 1999 2002 +3
Lines 139163 139175 +12
Branches 43716 43737 +21
==========================================
- Hits 20661 20647 -14
- Misses 95731 95776 +45
+ Partials 22771 22752 -19
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that yabloc works fine in your rosbag data, and the glog appears when the yabloc_pose_initializer
it is terminated.
LGTM 👍
It seems a very large PR will be merged, so I will merge after it to avoid trouble. |
…ode (autowarefoundation#7506) * change the node to component Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * remove useless node.cpp Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * add rclcpp_components as dependency Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
…ode (#7506) * change the node to component Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * remove useless node.cpp Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * add rclcpp_components as dependency Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Description
Componentize the node in localization/yabloc_pose_initializer.
Also, log output is changed from "screen" to "both".
Tests performed
1. Confirmed that yabloc works as conventional in logging_simulator
2. Confirmed that terminating the nodes process will output logs to both the terminal and the launch.log.
( The glog is printed only when using rclcpp_component customized by tier4. )
Effects on system behavior
The system behavior does not change.
Interface changes
The interface does not change.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.