Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(motion_utils)!: add autoware prefix and include dir #7539

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 17, 2024

Description

https://github.com/orgs/autowarefoundation/discussions/4881

We apologize for the trouble regarding autoware_ prefix support for Planning/Control and appreciate your cooperation.
Thanks to your help, we are almost done with the individual node support.

As a final step, we are going to create a PR with significant changes, and we would like to inform you of them.
By this PR, We will change as

  • tier4_autoware_utils to autoware_universe_utils
  • motion_utils to autoware_motion_utils

Although this PR contains many code changes, including a change to almost all nodes in planning/control, we plan to merge the change by a single PR for simplicity and to avoid conflicts and work-in-progress problems.
We will proceed with the utmost care so as not to bring any defects to the main branch, and we appreciate your understanding and cooperation.

related
autowarefoundation/autoware_tools#53

part of autowarefoundation/autoware#4569

Tests performed

psim
image

lsim
image

evaluator
https://evaluation.tier4.jp/evaluation/reports/5108f1ef-8656-58ba-96ae-1d831a471aaf?project_id=prd_jt
https://evaluation.tier4.jp/evaluation/reports/ffdd4991-3143-5338-b1e9-df6ba9903331?project_id=prd_jt

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Jun 17, 2024
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 33.85732% with 547 lines in your changes missing coverage. Please review.

Project coverage is 28.42%. Comparing base (507e3f4) to head (eaf3682).
Report is 36 commits behind head on main.

Files Patch % Lines
...th_dynamic_obstacle_avoidance_module/src/scene.cpp 0.00% 43 Missing ⚠️
..._obstacle_cruise_planner/src/planner_interface.cpp 7.14% 26 Missing ⚠️
...havior_path_lane_change_module/src/utils/utils.cpp 0.00% 20 Missing ⚠️
...ity_intersection_module/src/scene_intersection.cpp 0.00% 19 Missing ⚠️
...are_behavior_velocity_run_out_module/src/scene.cpp 0.00% 19 Missing ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 17 Missing ⚠️
..._start_planner_module/src/start_planner_module.cpp 0.00% 17 Missing ⚠️
...are_behavior_path_lane_change_module/src/scene.cpp 0.00% 15 Missing ⚠️
...ation_based_planner/optimization_based_planner.cpp 0.00% 13 Missing ⚠️
...or_path_planner_common/src/turn_signal_decider.cpp 45.83% 13 Missing ⚠️
... and 100 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7539       +/-   ##
===========================================
+ Coverage   14.84%   28.42%   +13.57%     
===========================================
  Files        1999      881     -1118     
  Lines      139163    75935    -63228     
  Branches    43716    33177    -10539     
===========================================
+ Hits        20661    21582      +921     
+ Misses      95731    48350    -47381     
+ Partials    22771     6003    -16768     
Flag Coverage Δ
differential 28.42% <33.85%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot removed the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Jun 18, 2024
@takayuki5168 takayuki5168 merged commit ad1be18 into autowarefoundation:main Jun 18, 2024
36 of 38 checks passed
@takayuki5168 takayuki5168 deleted the feat/autoware_motion_utils branch June 18, 2024 08:00
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…efoundation#7539)

refactor(motion_utils): add autoware prefix and include dir

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants