Targeted distro correction for OpenCV4 with melodic #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
image_geometry opencv_tests vision_opencv Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
Interim to ignore irrelative components
remove the inherent boost files
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
It mainly contains: - C++ interfaces and lib - python interfaces and corresponding C++ backend - all tests - remove boost dependence with C++11 or above instead Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
Add initial porting of ros2 cv_bridge
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
- broadcast.py - rosfacedetect.py - source.py Signed-off-by: gaoethan <ethan.gao@linux.intel.com>
port the opencv tests in ROS2
Add apache 2.0 license which aligns to ros2
Fix the coding style gap with ros2 requirement
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
copyright
cpplint
flake8
uncrustify
...
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
Fix the major issues from lint_cmake and python flake8/pep257
to avoid moudle not found issue Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
* Port image_geometry to ROS2. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
…ception#5) Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
* Build the image_geometry library shared. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Switch to using ament_cmake_ros for shared libraries by default. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Try to fix library not found problem on Windows. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fix silly typo. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add visibility_control for Windows compatibility. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Mark all inlines dllexport. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
As discussed in Slack, despite this dependency key, ROS 2 actually builds against upstream opencv (2.x) rather than opencv3.
…ception#9) This reverts commit 5ecbf59.
* pass filename to actually run the test * comment out poython tests as they've not been ported to ROS2 and we dont have python3 bindings with OpenCV ATM * putting my name in todo
- Replace assert_equal with assert
Add opencv as dependency and change assert_equal with assert
remove redundant ament_auto_lint to avoid build error
As JPEG2000 defaults to use JASPER as its codec, but it's disabled within the opencv library after Ubutnu Xenial due to security issues, one can enable to use after rebuild opencv library with jasper enabled on demand while necessary Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
remove jp2 for test_encode_decode_cv2_compressed
Add python3-numpy as build and execution dependency
* revert initialization in PinholeCameraModel constructor (ros2@d2e5edb) * revert message initialization in tests (ros2@ecbcd64)
Latest ros2 repo does not include ament_tools. Executing ament command results in error.
* [image_geometry] Install python package.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging Solosito's commit on ros-perception#308 into default
melodicbranch.