Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2][Windows] Include Boost to fix Windows build #290

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

jnoyola
Copy link
Contributor

@jnoyola jnoyola commented Sep 9, 2019

Addresses #289

The Boost dependency already exists, but it's failing the Windows build because it must be explicit.

This comment explains more of the long-term plan to remove this dependency:

I added a shim to rcpputils to remove the boost/endian dependency (https://github.com/ros2/rcpputils/blob/master/include/rcpputils/endian.hpp), we could potentially get that backported to dashing to completely remove boost dependency from C++, but there won't be any python until pybind11 lands.

@jnoyola
Copy link
Contributor Author

jnoyola commented Sep 21, 2019

I could use some help understanding this build failure. As far as I can tell, it looks like it just timed out when doing an apt-get install.

@seanyen
Copy link
Contributor

seanyen commented Oct 22, 2019

cc @mjcarroll I confirmed it is still an issue on Windows. The build error will manifest as below:

F:\workspace\ros2_ws\src\vision_opencv\cv_bridge\src\cv_bridge.cpp(39,10): fatal error C1083: Cannot open include file: 'boost/endian/conversion.hpp': No such file or directory [F:\workspace\ros2_ws\build\cv_bridge\src\cv_bridge.vcxproj]

After applying this fix, the build can run successfully.

@mjcarroll mjcarroll merged commit 667bf16 into ros-perception:ros2 Oct 22, 2019
@mjcarroll
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants