Add OpenCV4 support #308
Closed
Add OpenCV4 support #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solosito
force-pushed
the
opencv4-support
branch
from
81b4d91
to
e797e0e
Compare
|
Will opening a fourth PR on this topic make it more likely that this fix gets eventually merged? 😄 |
|
I think @solosito intended these changes for melodic, but it was forked from ros2 and tested with Melodic on Trusty Thar. I see that @mjcarroll labeled this as Creating a new pull request with CI test for Melodic/Bionic environment and referring this issue and #288 |
|
Apologies, I'm going to go ahead and run this through CI targeting
|
|
I'm also in favor of dropping OpenCV2 support as it isn't on any of our target platforms for the |
Merged
|
I'm going to close this off as I believe it's been resolved in #324. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR of changes from #288 to ros2 branch