-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apache 2.0 license which aligns to ros2 #216
Conversation
c6fe9b2
to
eda366c
Compare
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
Thanks @gaoethan to keep pushing for ROS2 support! However the code in this repository is licensed under the BSD license. In the same line of thought, there is existing code that didnt have a licence or copyright notice in it. I see that this has been licenced Apache 2.0 and copyright to Intel. Thanks! |
Somewhat related we generally recommend our development process to include a review of all changes by a second person. It looks like this PR was opened and merged immediately by the original author and didn't pass the Continuous Integration test before merging either. |
@mikaelarguedas Thanks for your advice ! it makes sense to keep the original license of the code. so let me double confirm the following for ROS2:
|
@tfoote The CI issue here is another issue I've already mentioned long time ago, because the CI backend here targets to the original ROS but not for ROS2, it fails for ROS2 branch commits unless the ROS2 branch can leverage official ROS2 CI backend. thanks ! |
👍 that sounds about right. I would add a subbullet in 1.
|
@mikaelarguedas sure. I'll tweak it to reflect that, thanks ! |
Include Apache 2.0 license to align with ros2
Signed-off-by: Ethan Gao ethan.gao@linux.intel.com