[Windows][ros2] Export interfaces for Shared Lib on Windows #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyen
force-pushed
the
dllexport_patch
branch
from
5bb6bcf
to
499f990
Compare
|
@mjcarroll I created another pull request to only address the |
mjcarroll
reviewed
Oct 16, 2019
mjcarroll
approved these changes
Oct 16, 2019
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, for a shared library, the interfaces must be explicitly decorated by proper
dllimportanddllexportusage. Otherwise, no imported library (.lib) will be generated for the downstream projects to consume at link time.This pull request is to add the interface export in a portable way provided by
CMake(instead of directly using MSVC specificdllimportanddllexport).This is a rework for #277