Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python3-numpy as build and execution dependency #243

Merged
merged 2 commits into from
Aug 17, 2018
Merged

Add python3-numpy as build and execution dependency #243

merged 2 commits into from
Aug 17, 2018

Conversation

gaoethan
Copy link
Contributor

numpy is necessary not only for test but also a dependency for building and runtime execution.
More details at ros2/rosdistro#260

@gaoethan gaoethan mentioned this pull request Aug 17, 2018
Closed
@mikaelarguedas
Copy link
Contributor

python3-numpy can now be removed as a test_depend.
test_depend is only necessary for additional dependencies needed uniquely for testing. As numpy is now listed as a build/exec dependency, the test_depend is not necessary anymore.

mikaelarguedas
mikaelarguedas approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gaoethan gaoethan merged commit 96beefa into ros-perception:ros2 Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaoethan @mikaelarguedas