-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acceptance tests for release 10.2.1 #35562
Acceptance tests for release 10.2.1 #35562
Conversation
The `getWebDriverSession` is not part of the `Mink\Driver\DriverInterface`, but is provided by the `Selenium2Driver`. So, as Sauce uses selenium grid, this will only be used when Sauce environment variables are set (other drivers do not have this).
…autocomplete list in webUI
Acceptance test PRs in |
…exposed by ocs api on share
this was added in #35204 but causes problems when an invalid request is done but the original `lastShareData` need to be accessed e.g `\Sharing::getMimeTypeOfLastSharedFile`
fa9b3a4
to
ff78380
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if CI passes it must be good!
I luv CI (not) https://drone.owncloud.com/owncloud/core/18468/754
Restarting drone build... |
CI is good. That is very nice. It means that all the latest acceptance test scenarios pass against 10.2.1 code. |
@phil-davis Could you remove #35306 from this PR and create a separate backport? |
I pushed a revert of #35306 on the end:
Removing the commit from the middle was causing annoying conflicts in later commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… list of files" This reverts commit 86066ad.
22def8d
to
b71b326
Compare
@patrickjahns this is ready to merge - you are the person controlling |
Description
Backport all acceptance test changes to
release-10.2.1
Then we will be running the most acceptance tests that we have, including various new test scenarios that have been added in the 2 months since
release-10.2.0
was branched off fromstable10
I could have tried to identify which acceptance test changes are additions of useful tests/test code fixes vs refactoring. And then just cherry-pick those that are additions of useful tests/test code fixes. But then many of those cherry-picks would have to be adjusted back to the way of doing things before the various refactorings. So it is much easier to cherry-pick everything. That way we get the acceptance test suite as it is currently working in
stable10
How Has This Been Tested?
CI
Types of changes
Checklist: