-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable10] Test Helper to read file from server #35158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
https://drone.owncloud.com/owncloud/core/17168/903 Restarted drone. |
Codecov Report
@@ Coverage Diff @@
## stable10 #35158 +/- ##
===========================================
Coverage 64.47% 64.47%
Complexity 20070 20070
===========================================
Files 1288 1288
Lines 76936 76936
Branches 1307 1307
===========================================
Hits 49606 49606
Misses 26949 26949
Partials 381 381
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #35158 +/- ##
===========================================
Coverage 64.47% 64.47%
Complexity 20070 20070
===========================================
Files 1288 1288
Lines 76936 76936
Branches 1307 1307
===========================================
Hits 49606 49606
Misses 26949 26949
Partials 381 381
Continue to review full report at Codecov.
|
This happens on function waitTillJqueryIsLoaded(Session $session) {
// language=JS
$script = 'function blockTillJqueryIsLoaded() {
if (window.jQuery) {
return;
} else {
setTimeout(function() { blockTillJQueryIsLoaded() }, 50);
}
};
blockTillJqueryIsLoaded();
';
$session->executeScript($script);
} |
backport of #35151