Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Remove deprecated default attributes test steps #35452

Merged
merged 4 commits into from
Jun 7, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 7, 2019

Backport #35451

plus related changes to step text of bundled encryption and user_management acceptance tests that are in core stable10

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #35452 into stable10 will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35452      +/-   ##
==============================================
+ Coverage       64.69%   64.71%   +0.02%     
- Complexity      20103    20163      +60     
==============================================
  Files            1293     1293              
  Lines           76977    77118     +141     
  Branches         1300     1300              
==============================================
+ Hits            49797    49904     +107     
- Misses          26796    26830      +34     
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <ø> (+0.02%) 20163 <ø> (+60) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/CalendarObject.php 94.11% <0%> (-2.66%) 18% <0%> (ø)
apps/dav/lib/DAV/Sharing/Plugin.php 68.29% <0%> (-0.94%) 14% <0%> (ø)
lib/private/Archive/TAR.php 86.33% <0%> (-0.9%) 66% <0%> (+10%)
apps/dav/lib/CardDAV/AddressBook.php 76.19% <0%> (-0.6%) 21% <0%> (ø)
apps/dav/lib/CalDAV/Calendar.php 85.47% <0%> (-0.38%) 48% <0%> (+4%)
lib/private/Memcache/ArrayCache.php 100% <0%> (ø) 19% <0%> (+2%) ⬆️
lib/private/Console/Application.php 0% <0%> (ø) 23% <0%> (+4%) ⬆️
apps/dav/lib/CalDAV/CalendarHome.php 0% <0%> (ø) 19% <0%> (+12%) ⬆️
lib/private/Files/Cache/Cache.php 97.61% <0%> (ø) 110% <0%> (ø) ⬇️
lib/private/Files/Node/File.php 95.77% <0%> (+0.18%) 32% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619572c...874bc85. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #35452 into stable10 will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35452      +/-   ##
==============================================
+ Coverage       64.69%   64.71%   +0.02%     
- Complexity      20103    20163      +60     
==============================================
  Files            1293     1293              
  Lines           76977    77118     +141     
  Branches         1300     1300              
==============================================
+ Hits            49797    49904     +107     
- Misses          26796    26830      +34     
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <ø> (+0.02%) 20163 <ø> (+60) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/CalendarObject.php 94.11% <0%> (-2.66%) 18% <0%> (ø)
apps/dav/lib/DAV/Sharing/Plugin.php 68.29% <0%> (-0.94%) 14% <0%> (ø)
lib/private/Archive/TAR.php 86.33% <0%> (-0.9%) 66% <0%> (+10%)
apps/dav/lib/CardDAV/AddressBook.php 76.19% <0%> (-0.6%) 21% <0%> (ø)
apps/dav/lib/CalDAV/Calendar.php 85.47% <0%> (-0.38%) 48% <0%> (+4%)
lib/private/Memcache/ArrayCache.php 100% <0%> (ø) 19% <0%> (+2%) ⬆️
lib/private/Console/Application.php 0% <0%> (ø) 23% <0%> (+4%) ⬆️
apps/dav/lib/CalDAV/CalendarHome.php 0% <0%> (ø) 19% <0%> (+12%) ⬆️
lib/private/Files/Cache/Cache.php 97.61% <0%> (ø) 110% <0%> (ø) ⬇️
lib/private/Files/Node/File.php 95.77% <0%> (+0.18%) 32% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619572c...874bc85. Read the comment docs.

@phil-davis phil-davis force-pushed the stable10-remove-default-attributes-steps branch from 874bc85 to f5102ab Compare June 7, 2019 08:28
@phil-davis phil-davis merged commit 84571e1 into stable10 Jun 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-remove-default-attributes-steps branch June 7, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants