Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable10] Do not use skeleton file when not required #35424

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jun 4, 2019

Backport #35405

@phil-davis phil-davis force-pushed the stable10-not-use-skeleton-files branch from 20fad95 to a1f3c48 Compare June 4, 2019 11:40
@phil-davis
Copy link
Contributor

Rebased to get good CI

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #35424 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35424   +/-   ##
===========================================
  Coverage       64.68%   64.68%           
  Complexity      20103    20103           
===========================================
  Files            1293     1293           
  Lines           76976    76976           
  Branches         1300     1300           
===========================================
  Hits            49793    49793           
  Misses          26799    26799           
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.83% <ø> (ø) 20103 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c374543...a1f3c48. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #35424 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35424   +/-   ##
===========================================
  Coverage       64.68%   64.68%           
  Complexity      20103    20103           
===========================================
  Files            1293     1293           
  Lines           76976    76976           
  Branches         1300     1300           
===========================================
  Hits            49793    49793           
  Misses          26799    26799           
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.83% <ø> (ø) 20103 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c374543...a1f3c48. Read the comment docs.

@phil-davis phil-davis merged commit d508972 into stable10 Jun 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-not-use-skeleton-files branch June 4, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants