Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use skeleton file when not required #35405

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Do not use skeleton file when not required #35405

merged 1 commit into from
Jun 5, 2019

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jun 3, 2019 •
edited by individual-it
Loading

Description

Do not use skeleton folder for webUIAcceptShare and webUIAdminSettings suites to speed up CI.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@dpakach dpakach self-assigned this Jun 3, 2019
@dpakach dpakach marked this pull request as ready for review June 3, 2019 08:02
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #35405 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35405   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.04% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647525b...1f60a93. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 3, 2019 •
edited
Loading

Codecov Report

Merging #35405 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35405   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.04% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cec72...9904457. Read the comment docs.

paurakhsharma
paurakhsharma reviewed Jun 3, 2019
View reviewed changes
tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature Outdated
| username |
| user1 |
| user2 |
# Given these users have been created with default attributes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot to remove comments

paurakhsharma
paurakhsharma reviewed Jun 3, 2019
View reviewed changes
Copy link
Member

@paurakhsharma paurakhsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the comments.

tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature
| /simple-folder%20(2)/from_user1/ |
| /simple-folder%20(3)/from_user2/ |
| /simple-folder/from_user1/ |
| /simple-folder%20(2)/from_user2/ |

Scenario: receive shares with same name from different users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scenario is the same as the scenario in line 33. Is there a special reason for this?

@paurakhsharma paurakhsharma mentioned this pull request Jun 3, 2019
Closed
19 tasks
@dpakach dpakach mentioned this pull request Jun 4, 2019
Merged
@phil-davis
Copy link
Contributor

Backport stable10 #35424

@phil-davis
Copy link
Contributor

Rebased to get good CI

@phil-davis
Copy link
Contributor

It got a dumb composer error in drone https://drone.owncloud.com/owncloud/core/18013/830
I will rebase again so it restarts CI.

@phil-davis
Copy link
Contributor

No code coverage result has come. I have rebased and force-pushed again. Maybe it will come next time?

@DeepDiver1975 DeepDiver1975 merged commit db70679 into master Jun 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the not-use-skeleton-file branch June 5, 2019 07:56
@individual-it individual-it mentioned this pull request Sep 24, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paurakhsharma paurakhsharma paurakhsharma left review comments

@individual-it individual-it individual-it approved these changes

@skshetry skshetry Awaiting requested review from skshetry

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@dpakach dpakach

Labels
4 - To release dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dpakach @phil-davis @individual-it @paurakhsharma @DeepDiver1975