[stable10] use a multi line approach to display share autocomplete

[DeepDiver1975]

Description

Related Issue

• Fixes 10.2 RC1 Share with "federation" text is cut off #35098

How Has This Been Tested?

• ✋

Screenshots (if appropriate):

Federated or Guest

Group

With additional user information

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[pmaier1]

This is so beautiful ❤️

[micbar]

@DeepDiver1975 Seems like the WebUI Sharing tests have on failing Scenario

[phil-davis]

With this PR the webUI has a separate UI element that displays the type of the potential share recipient. e.g. "User", "Group", "Federated". Previously this information was just appended in text after the display name "(group)", "(federated)".

The webUI tests need enhancing so that they process this extra UI element when working out which share recipient to click on in the dropdown list, and when checking if the correct matching entries are found in the dropdown list.

I will look.

[codecov]

Codecov Report

Merging #35397 into stable10 will decrease coverage by 0.02%.
The diff coverage is 57.14%.

@@              Coverage Diff               @@
##             stable10   #35397      +/-   ##
==============================================
- Coverage       64.68%   64.65%   -0.03%     
  Complexity      20103    20103              
==============================================
  Files            1293     1293              
  Lines           76976    76977       +1     
  Branches         1300     1301       +1     
==============================================
- Hits            49793    49771      -22     
- Misses          26799    26821      +22     
- Partials          384      385       +1

Flag	Coverage Δ	Complexity Δ
#javascript	53.84% <57.14%> (-0.01%)	0 <0> (ø)
#phpunit	65.8% <ø> (-0.04%)	20103 <ø> (ø)

Impacted Files	Coverage Δ	Complexity Δ
core/js/sharedialogview.js	78.1% <57.14%> (-0.68%)	0 <0> (ø)
apps/files_sharing/lib/External/Manager.php	77.38% <0%> (-12.62%)	32% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e301daf...f11dd61. Read the comment docs.

[codecov]

Codecov Report

Merging #35397 into stable10 will increase coverage by <.01%.
The diff coverage is 57.14%.

@@              Coverage Diff               @@
##             stable10   #35397      +/-   ##
==============================================
+ Coverage        64.8%    64.8%   +<.01%     
  Complexity      20183    20183              
==============================================
  Files            1293     1293              
  Lines           77170    77173       +3     
  Branches         1300     1301       +1     
==============================================
+ Hits            50010    50012       +2     
  Misses          26776    26776              
- Partials          384      385       +1

Flag	Coverage Δ	Complexity Δ
#javascript	53.85% <57.14%> (ø)	0 <0> (ø)	⬇️
#phpunit	65.96% <ø> (ø)	20183 <ø> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
core/js/sharedialogview.js	78.6% <57.14%> (-0.19%)	0 <0> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d1a344...4644552. Read the comment docs.

[phil-davis]

This is specially useful for setting up a share on the remote (federated) server, and giving it some permissions.
We want to use the API to set up stuff on the remote server, rather than the webUI, because we do not want to depend on particular details of the webUI on the remote server. (The remote server might be running some older release/code that has a bit different webUI behaviour, but it should have compatible API behaviour within the same major version)

[phil-davis]

In the case of this particular PR, the webUI dropdown sharing list has changed its format/text a bit, and so trying to run the new webUI sharing acceptance test code against a remote server without the PR would fail.

[micbar]

@phil-davis Great Work! Keep on :-)

[phil-davis]

@individual-it this is ready for review of the acceptance test changes.

[individual-it]

tests look good to me

[phil-davis]

@pmaier1 and anyone else who cares, this is "good to go" from a technical POV.
If you are happy with it, then we can make the forward-port to master and merge both PRs.
And I guess it will be released in the next minor release?
(not for 10.2.1 ?)

[phil-davis]

Forward port to master is PR #35486

[pmaier1]

And I guess it will be released in the next minor release?
(not for 10.2.1 ?)

Yes, something for the next minor.

[phil-davis]

See comment on forward port about codecov #35486 (comment)
Needs to be decided before merging here, so that the forward port and this stable10 PR are the same.

[phil-davis]

I cherry-picked commit "add js test for remote share with server" from the master PR #35486