-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust guest sharing dropdown text #337
Conversation
Note: this change to the guests app will need to be released in sync with the release of the corresponding change in core. Probably that will be core |
f4f6bc0
to
107ead8
Compare
Nice! Thanks a lot for taking care 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
@phil-davis Please force push to re run CI |
107ead8
to
c45147d
Compare
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=========================================
Coverage 17.87% 17.87%
Complexity 101 101
=========================================
Files 11 11
Lines 537 537
=========================================
Hits 96 96
Misses 441 441 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=========================================
Coverage 17.87% 17.87%
Complexity 101 101
=========================================
Files 11 11
Lines 537 537
=========================================
Hits 96 96
Misses 441 441 Continue to review full report at Codecov.
|
CI is running again - let's see... |
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=========================================
Coverage 17.87% 17.87%
Complexity 101 101
=========================================
Files 11 11
Lines 537 537
=========================================
Hits 96 96
Misses 441 441 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=========================================
Coverage 17.87% 17.87%
Complexity 101 101
=========================================
Files 11 11
Lines 537 537
=========================================
Hits 96 96
Misses 441 441 Continue to review full report at Codecov.
|
If there might be a guest app release needed before core |
Description
The recent enhancement of the webUI sharing dropdown list in core PR owncloud/core#35397 now puts the user type (local, federated, guest etc) on a second line. The extra
(guest)
in brackets that the guest app is putting is no longer needed and just adds redundant data to the user experience.Remove the
(guest)
in brackets from the sharing dropdown list.Related Issue
owncloud/core#35098
Motivation and Context
Make the guests sharing webUI behavior match the recent changes in the core PR owncloud/core#35397
How Has This Been Tested?
Observing local webUI test runs to see that the share dropdown no longer has the extra
(guest)
text.Screenshots (if appropriate):
Types of changes
Checklist: