[feature/sharing-user-groups] Implementation of Sharing with Users, Groups and Remote Users, Public Links #358

hosy · 2019-04-12T13:30:57Z

Description

Implementation of User, Group and Remote Sharing for files and folders

Related Issue

#351
#275
#292

Motivation and Context

As one of a main feature of ownCloud it is now possible the share files and folders to other users.

How Has This Been Tested?

Sharing with Users, Groups

shared files and folders should have a shared icon in the file list (folders have a special folder icon)
on a file, which is currently not shared, tap on the More button
- if sharing is possible for this item (depends on server capability, permissions) there is a new item "Share file" or "Share folder"
- Tapping on this item will open the Sharing overview, where you can search for a new recipient
on an item which is shared by you, you will see how many recipients are on this share
if the item has public links, these are also visible, but cannot edited at the moment
in the Sharing overview you can edit, delete and add recipients
by selecting a share recipient you can change permissions, based on the item type
if you have reshared the item, you can edit permissions for this recipient

Public Links

if item is sharable, there is a menu item Create Public Link, if not there is no menu entry
tap on it will create a new public link with known options
please test it with all regarded server capabilities

Private Link

open the menu item Create Public Link
on the top of the screen there is a button Copy Private Link
this will copy the private link url to the pasteboard

Sorting in file list

you can now sort items in file list, if it is shared

In the process of implementation, the following was changed:

Issue #292:

Enter a search term in file list, which has no matches
Delete all share recipients of an item
If the keyboard is on screen, all text labels should be visible and not hidden by keyboard

Add Menu

In file list, tap on Add button
Menu items are now left aligned and have an left aligned icon

More Menu

Action items are now left aligned and have left aligned icons

Quick Access

This view was necessary to show pending shares, which needs to be accepted by the user.

Pending Shares

if the user has pending shares,

Shares

Collections

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

Test plan:

https://github.com/owncloud/QA/blob/master/Mobile/iOS-app/Sharing.md

Bugfixing:

codecov · 2019-04-12T14:48:16Z

Codecov Report

Merging #358 into master will decrease coverage by 3.02%.
The diff coverage is 14.76%.

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage   30.04%   27.02%   -3.03%     
==========================================
  Files         245      263      +18     
  Lines       17106    19828    +2722     
==========================================
+ Hits         5140     5358     +218     
- Misses      11966    14470    +2504

Impacted Files	Coverage Δ
...Client/Sharing/PublicLinkTableViewController.swift	`0% <0%> (ø)`
ownCloud/Client/Viewer/DisplayViewController.swift	`0% <0%> (ø)`	⬆️
ownCloud/SDK Extensions/OCCore+Extension.swift	`0% <0%> (ø)`
ownCloud/UIKit Extensions/UIImage+Extension.swift	`40.62% <0%> (-21.28%)`	⬇️
ownCloud/UIKit Extensions/Array+Extension.swift	`0% <0%> (ø)`
ownCloud/UI Elements/RoundedLabel.swift	`0% <0%> (ø)`
...t/Actions/Actions+Extensions/DuplicateAction.swift	`10% <0%> (-0.77%)`	⬇️
ownCloud/Client/Actions/MoreViewHeader.swift	`0% <0%> (ø)`	⬆️
ownCloud/SDK Extensions/OCShare+Extension.swift	`0% <0%> (ø)`
ownCloud/Client/Sharing/ShareClientItemCell.swift	`0% <0%> (ø)`
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f6b99...633b098. Read the comment docs.

- new toggle action - set permissions (unfinished)

- handling shared by me and shared with me in file detail view - disable permission editing, if user is not the owner - delete receipient - added sorting by "shared" in file list

- add recipient to share

- fixes for recipients search

- added header title to search recipients

- refactored code

- fixed keyboard height constraint in MessageView - added localization strings - fixed updating shares handler

- More menu: left aligned text, added icons - fixes for UI glitches in more menu (correct height) - fixed wrong table header height in MoreStaticTableViewController, for sections without section title - close more menu before opening sharing overview

- fixed tint color for image

- updated to new sharing SDK (which fixes update notification)

- added delete recipient by swiping in overview

…sharing-user-groups # Conflicts: # ios-sdk # ownCloud.xcodeproj/project.pbxproj # ownCloud/Client/Actions/Action.swift # ownCloud/Client/Actions/Actions+Extensions/DuplicateAction.swift # ownCloud/Client/ClientQueryViewController.swift # ownCloud/Resources/en.lproj/Localizable.strings

- new function to detect if user can edit OCShare

felix-schwarz · 2019-06-06T09:09:33Z

@jesmrec Regarding (10): that's fixed with the latest commit

…e exists

…h showed the content above

…-app into feature/sharing-user-groups

hosy · 2019-06-06T09:51:09Z

(32)

Share several items with an user in another server (federated)

Open the recipient

Current: Notification is correct, but in the list of pending invites, only one share appears. Once you accept or decline the next one is there
Expected: List of pending invites

@jesmrec fixed!

jesmrec · 2019-06-06T09:55:32Z

about (10), not posible to share if the username last character is '@'

Request is sent with shareType: 6 instead of shareType: 0

jesmrec · 2019-06-07T06:52:38Z

with commit a951f4d (10) is still reproducible. Is it pointing to the right SDK commit? @felix-schwarz

jesmrec · 2019-06-07T07:41:19Z

(10) -> fixed!

jesmrec · 2019-06-07T08:42:31Z

(33) [FIXED]

Share with user/group a folder
Browse into the folder and try to delete items (permission was granted in the creation)

Current: Unshare option available, no way to delete.
Expected: Unsharing is an option for the "source" item (shared folder in step 1.), the items inside can be removed (if granted)

jesmrec · 2019-06-07T08:43:49Z

(34) (improvement)

Open "Share this file/folder"
Search and choose a recipient
Remove connection
Save

Current: error can be improved

- Fixed retain cycle - Code cosmetics

hosy · 2019-06-07T09:16:29Z

(33)

Share with user/group a folder

Browse into the folder and try to delete items (permission was granted in the creation)

Current: Unshare option available, no way to delete.
Expected: Unsharing is an option for the "source" item (shared folder in step 1.), the items inside can be removed (if granted)

@jesmrec good catch!

…em(from: core) methods - Adapted DeleteAction and UnshareAction so that deletion is available inside shared folders where the owner allowed deletion

felix-schwarz · 2019-06-07T09:44:22Z

(33)

Share with user/group a folder

Browse into the folder and try to delete items (permission was granted in the creation)

Current: Unshare option available, no way to delete.
Expected: Unsharing is an option for the "source" item (shared folder in step 1.), the items inside can be removed (if granted)

@jesmrec Fixed as of c06f6b9. The "Unshare" option is only shown for the actually shared "root item", not the items inside it though. Would've found it confusing otherwise.

jesmrec · 2019-06-07T10:27:42Z

(35) [FIXED]

In web UI:

In app:

Current: Share and Delete are hidden
Expected: Share and Delete are visible and unchecked

hosy · 2019-06-07T11:41:22Z

(35)

In web UI:

In app:

Current: Share and Delete are hidden
Expected: Share and Delete are visible and unchecked

@jesmrec it was decided to hide elements, which cannot be selected -> [WON`T FIX]

jesmrec · 2019-06-07T11:52:00Z

But they can be selected, this option is to mark permissions by default when the share is being created.

F. ex, in webUI, with the set up:

when you create a share:

which behaviour is the correct, then?

CC @pmaier1

hosy · 2019-06-07T12:07:54Z

But they can be selected, this option is to mark by default when the share is being created.

F. ex, in webUI, with the set up:

when you create a share:

which behaviour is the correct, then?

CC @pmaier1

@jesmrec what do you mean exactly? Sharing and Deleting is not allowed or is not a default permission?

jesmrec · 2019-06-07T12:15:35Z

i mean.

You see this in the webUI

options "Share" and "delete" unchecked, but you can check them if you want to grant those permissions.

In the app:

"Share" and "Delete" are hidden, and you do no have the choice to grant those permissions.

… list

- disable public link section, if not enabled

- do not show share menu item, if sharing api is disabled

#351 added first draft of Sharing with users, groups, remotes

d0d21c0

hosy added work in progress feature:sharing labels Apr 12, 2019

hosy added this to the 1.1.0-Next milestone Apr 12, 2019

hosy self-assigned this Apr 12, 2019

hosy added 10 commits April 17, 2019 13:43

- changes for shared with user handling

fcce307

- new toggle action - set permissions (unfinished)

- added icon in file list, if item is shared

9a7bc50

- handling shared by me and shared with me in file detail view - disable permission editing, if user is not the owner - delete receipient - added sorting by "shared" in file list

setting permissions is now working

33555b5

using correct sdk commit

62fab58

changed query, if item is shared

1915662

- search for recipients

8902510

- add recipient to share

removed deleted SharingSearchResults Controller

278c2c6

- removed unneeded elements

4168fc4

- fixes for recipients search

- fixed crash on adding recipient to share

8df0575

- added header title to search recipients

- added activity view when searching shares

20846db

- refactored code

hosy added 2 commits April 22, 2019 22:21

fixed Theming for searchBar and selecting rows

293bc87

- moved MessageView to own class

22d2d73

- fixed keyboard height constraint in MessageView - added localization strings - fixed updating shares handler

hosy mentioned this pull request Apr 24, 2019

"No matches" label in file search is hidden by keyboard #292

Closed

hosy added 4 commits April 29, 2019 15:18

- fixed missing sharing row

efaabe8

- fixed tint color for image

- changed image alignment

94e0482

- updated to new sharing SDK (which fixes update notification)

- fixed wrong usage of Sharing SDK-API

94c6a53

- added delete recipient by swiping in overview

hosy changed the base branch from master to release/1.0.1 April 30, 2019 07:17

hosy changed the base branch from release/1.0.1 to master April 30, 2019 08:48

hosy added 2 commits April 30, 2019 11:44

- fixed delete recipient, only if user has permissions

a91ef8a

- new function to detect if user can edit OCShare

hosy added 3 commits June 6, 2019 11:22

fixed QA finding (32), that only one pending invite was shown, if mor…

50e767a

…e exists

fixed QA finding (27), MessageView has a left and right padding, whic…

2ea337d

…h showed the content above

Merge branch 'feature/sharing-user-groups' of github.com:owncloud/ios…

a951f4d

…-app into feature/sharing-user-groups

- Correctly handle local user names ending with an "@" (via SDK update)

b8b1c60

- Added OCItem array extension .sharedWithUser

2982081

- Fixed retain cycle - Code cosmetics

- Added new OCItem.shareRootItem(from: core) and OCItem.isShareRootIt…

c06f6b9

…em(from: core) methods - Adapted DeleteAction and UnshareAction so that deletion is available inside shared folders where the owner allowed deletion

felix-schwarz approved these changes Jun 7, 2019

View reviewed changes

fixed QA finding (35), show options, if not set in default permission…

e6f32cc

… list

jesmrec self-requested a review June 7, 2019 13:05

jesmrec approved these changes Jun 7, 2019

View reviewed changes

hosy added 2 commits June 7, 2019 16:22

- enable "Links" menu item, if public link sharing is disabled

668fdae

- disable public link section, if not enabled

- only show link menu item, if bookmark is online

633b098

- do not show share menu item, if sharing api is disabled

hosy merged commit 0bd5944 into master Jun 8, 2019

delete-merged-branch bot deleted the feature/sharing-user-groups branch June 8, 2019 07:09

jesmrec mentioned this pull request Jun 14, 2019

Roadmap #94

Open

45 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature/sharing-user-groups] Implementation of Sharing with Users, Groups and Remote Users, Public Links #358

[feature/sharing-user-groups] Implementation of Sharing with Users, Groups and Remote Users, Public Links #358

hosy commented Apr 12, 2019 •

edited by jesmrec

Loading

codecov bot commented Apr 12, 2019 •

edited

Loading

felix-schwarz commented Jun 6, 2019

hosy commented Jun 6, 2019

(32)

jesmrec commented Jun 6, 2019 •

edited

Loading

jesmrec commented Jun 7, 2019 •

edited

Loading

jesmrec commented Jun 7, 2019

jesmrec commented Jun 7, 2019 •

edited

Loading

jesmrec commented Jun 7, 2019

hosy commented Jun 7, 2019

(33)

felix-schwarz commented Jun 7, 2019

(33)

jesmrec commented Jun 7, 2019 •

edited

Loading

hosy commented Jun 7, 2019

(35)

jesmrec commented Jun 7, 2019 •

edited

Loading

hosy commented Jun 7, 2019

jesmrec commented Jun 7, 2019

[feature/sharing-user-groups] Implementation of Sharing with Users, Groups and Remote Users, Public Links #358

[feature/sharing-user-groups] Implementation of Sharing with Users, Groups and Remote Users, Public Links #358

Conversation

hosy commented Apr 12, 2019 • edited by jesmrec Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Sharing with Users, Groups

Public Links

Private Link

In the process of implementation, the following was changed:

Quick Access

Types of changes

Checklist:

Test plan:

Bugfixing:

codecov bot commented Apr 12, 2019 • edited Loading

Codecov Report

felix-schwarz commented Jun 6, 2019

hosy commented Jun 6, 2019

(32)

jesmrec commented Jun 6, 2019 • edited Loading

jesmrec commented Jun 7, 2019 • edited Loading

jesmrec commented Jun 7, 2019

jesmrec commented Jun 7, 2019 • edited Loading

(33) [FIXED]

jesmrec commented Jun 7, 2019

(34) (improvement)

hosy commented Jun 7, 2019

(33)

felix-schwarz commented Jun 7, 2019

(33)

jesmrec commented Jun 7, 2019 • edited Loading

(35) [FIXED]

hosy commented Jun 7, 2019

(35)

jesmrec commented Jun 7, 2019 • edited Loading

hosy commented Jun 7, 2019

jesmrec commented Jun 7, 2019

hosy commented Apr 12, 2019 •

edited by jesmrec

Loading

codecov bot commented Apr 12, 2019 •

edited

Loading

jesmrec commented Jun 6, 2019 •

edited

Loading

jesmrec commented Jun 7, 2019 •

edited

Loading

jesmrec commented Jun 7, 2019 •

edited

Loading

jesmrec commented Jun 7, 2019 •

edited

Loading

jesmrec commented Jun 7, 2019 •

edited

Loading