-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 6 for refactoring bittensor/subtensor.py - class CamelCase #1935
Conversation
…-6' into refactoring/roman/subtensor-part-6
# Double import allows using class `Subtensor` by referencing `bittensor.Subtensor` and `bittensor.subtensor`. | ||
# This will be available for a while until we remove reference `bittensor.subtensor` | ||
from .subtensor import Subtensor | ||
from .subtensor import Subtensor as subtensor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't remove the bt.subtensor factory design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still under discussion. Both options are available now, as we discussed in the chat.
as a Python Developer and bittensor user, I must say that it may seem small, but moving towards getting rid of confusing classes masking over the modules may seem silly, but is an awesome, quality of life change. Both I and my IDE are getting confused with |
Thank you for such warm feedback! We really try to do everything so that the community gets the best experience both as developers and as users who are not related to programming. The more and more detailed community's requests, feedback, and suggestions we receive, the better the Bittensor becomes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, but revert the license wording change. I do like adding some kind of deprecation warning for the subtensor
that we discussed, but it's not immediately necessary.
Since the refactoring of this module would turn into a large project, it was decided to divide it into several stages.
This is part 6: Renaming class 1 to comply with PEP8 and avoid namespace conflict. Refactor all references to the changed name.
Part 1 #1911
Part 2 #1913
Part 3 #1923
Part 4 #1931
Part 5 #1934