-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 4 for refactoring bittensor/subtensor.py #1931
Conversation
there are a few But other than that, LGTM. |
This is correct docstring. First For the comparison another example: def unstake_multiple(
self,
wallet: "bittensor.wallet",
hotkey_ss58s: List[str],
amounts: Optional[List[Union["Balance", float]]] = None,
wait_for_inclusion: bool = True,
wait_for_finalization: bool = False,
prompt: bool = False,
) -> bool:
"""
...
Args:
amounts (Optional[List[Union[Balance, float]]], optional): The am ...
...
""" It was confusing me too then I realized what does it mean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the refactoring of this module would turn into a large project, it was decided to divide it into several stages.
This is part 4: current part affects everything up to the subtensor().tx_rate_limit() method.
Test coverage improved.
Part 1 #1911
Part 2 #1913
Part 3 #1923