Part 4 for refactoring bittensor/subtensor.py

[roman-opentensor]

Since the refactoring of this module would turn into a large project, it was decided to divide it into several stages.

This is part 4: current part affects everything up to the subtensor().tx_rate_limit() method.
Test coverage improved.

Part 1 #1911
Part 2 #1913
Part 3 #1923

[opendansor]

there are a few
Args: (Optional[int], optional):

But other than that, LGTM.

[roman-opentensor]

there are a few Args: (Optional[int], optional):

But other than that, LGTM.

This is correct docstring. First Optional[int] means the type of the argument. The second one optional means that you you may not provide this argument and in this case it have to be equal to default value.

For the comparison another example:

    def unstake_multiple(
        self,
        wallet: "bittensor.wallet",
        hotkey_ss58s: List[str],
        amounts: Optional[List[Union["Balance", float]]] = None,
        wait_for_inclusion: bool = True,
        wait_for_finalization: bool = False,
        prompt: bool = False,
    ) -> bool:
        """ 
        ...
        Args:
            amounts (Optional[List[Union[Balance, float]]], optional): The am ...
        ...
        """

It was confusing me too then I realized what does it mean.

[ibraheem-opentensor]

Overall LGTM
I personally prefer the left-hand style more due to its structure 😄 but that's just me

[roman-opentensor]

Overall LGTM I personally prefer the left-hand style more due to its structure 😄 but that's just me

the essence of my approach is that first we check edge cases and undesirable cases, and then happy)