refactoring/roman/subtensor-part-2 #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subtensor().validator_logits_divergence() last refactored method
3 tasks
3 tasks
| error (str): Error message if transfer failed. | ||
| """ | ||
|
|
||
| @retry(delay=2, tries=3, backoff=2, max_delay=4, logger=_logger) | ||
| @retry(delay=1, tries=3, backoff=2, max_delay=4, logger=_logger) |
There was a problem hiding this comment.
Why the change to delay?
There was a problem hiding this comment.
Changing the delay from 2 to 1 will reduce the initial delay before the first retry and generally shorten the time between retries. This will speed up the retry process in case of errors.
When I tested changing the delay to 1 second, there were no errors, but the command execution time was reduced.
bittensor/subtensor.py
Outdated
| @@ -1431,7 +1426,8 @@ def get_existential_deposit(self, block: Optional[int] = None) -> Optional[Balan | |||
| balances below this threshold can be reaped to conserve network resources. | |||
|
|
|||
| Args: | |||
| block (Optional[int], optional): Block number at which to query the deposit amount. If ``None``, the current block is used. | |||
| block (Optional[int], optional): Block number at which to query the deposit amount. If ``None``, the | |||
There was a problem hiding this comment.
Do we need , optional if we already have Optional[int]?
There was a problem hiding this comment.
good point. thanks
bittensor/subtensor.py
Outdated
| placeholder1 (int, optional): Placeholder parameter for future extensions. Default is `0`. | ||
| placeholder2 (int, optional): Placeholder parameter for future extensions. Default is `0`. | ||
| wait_for_inclusion (bool, optional): Waits for the transaction to be included in a block. Default is | ||
| `False`. |
There was a problem hiding this comment.
Maybe use the double backticks for these docstring annotations, to keep consistency.
There was a problem hiding this comment.
yeah, good idea!
subtensor().validator_logits_divergence() last refactored method
opendansor
reviewed
May 21, 2024
opendansor
reviewed
May 21, 2024
opendansor
reviewed
May 21, 2024
opendansor
reviewed
May 21, 2024
opendansor
reviewed
May 21, 2024
Also, high-level refactoring (explicit places) was carried out for the entire module. More detailed refactoring will continue with the "validator_logits_divergence" method.
roman-opentensor
force-pushed
the
refactoring/roman/subtensor-part-2
branch
from
9e9f3d3
to
540604e
Compare
opendansor
reviewed
May 22, 2024
gus-opentensor
approved these changes
May 22, 2024
opendansor
approved these changes
May 22, 2024
thewhaleking
approved these changes
May 22, 2024
ibraheem-opentensor
approved these changes
May 22, 2024
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the refactoring of this module would turn into a large project, it was decided to divide it into several stages.
This is part 2: current part affects everything up to the subtensor().validator_logits_divergence() method.
Part 1 #1911