Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 5 for refactoring bittensor/subtensor.py #1934

Merged
merged 6 commits into from
May 24, 2024

Conversation

roman-opentensor
Copy link
Contributor

Since the refactoring of this module would turn into a large project, it was decided to divide it into several stages.

This is part 5: current part affects everything in this document except of renaming class subtensor according to the CamelCase rule.

Test coverage improved.

Part 1 #1911
Part 2 #1913
Part 3 #1923
Part 4 #1931

… it was decided to divide it into several stages.

This is part 5: current part affects everything in this document except of renaming class `subtensor` according to the CamelCase rule.

Test coverage improved.

Part 1 #1911
Part 2 #1913
Part 3 #1923
Part 4 #1931
@roman-opentensor roman-opentensor requested a review from a team May 24, 2024 03:32
@roman-opentensor roman-opentensor self-assigned this May 24, 2024
@roman-opentensor roman-opentensor changed the base branch from master to staging May 24, 2024 03:33
@roman-opentensor roman-opentensor marked this pull request as ready for review May 24, 2024 03:40
roman-opentensor added a commit that referenced this pull request May 24, 2024
… it was decided to divide it into several stages.

This is part 6: Renaming class 1 to comply with PEP8 and avoid namespace conflict. Refactor all references to the changed name.

Part 1 #1911
Part 2 #1913
Part 3 #1923
Part 4 #1931
Part 5 #1934
roman-opentensor added a commit that referenced this pull request May 24, 2024
… it was decided to divide it into several stages.

This is part 6: Renaming class 1 to comply with PEP8 and avoid namespace conflict. Refactor all references to the changed name.

Part 1 #1911
Part 2 #1913
Part 3 #1923
Part 4 #1931
Part 5 #1934
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall pretty good. Just a few things.

bittensor/subtensor.py Outdated Show resolved Hide resolved
bittensor/subtensor.py Outdated Show resolved Hide resolved
bittensor/subtensor.py Outdated Show resolved Hide resolved
bittensor/subtensor.py Outdated Show resolved Hide resolved
tests/unit_tests/test_subtensor.py Outdated Show resolved Hide resolved
tests/unit_tests/test_subtensor.py Outdated Show resolved Hide resolved
tests/unit_tests/test_subtensor.py Outdated Show resolved Hide resolved
tests/unit_tests/test_subtensor.py Outdated Show resolved Hide resolved
@roman-opentensor roman-opentensor merged commit 6861235 into staging May 24, 2024
11 checks passed
@roman-opentensor roman-opentensor deleted the refactoring/roman/subtensor-part-5 branch May 24, 2024 20:14
@roman-opentensor roman-opentensor linked an issue May 24, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bittensor.subtensor module refactoring
3 participants