Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part 1 for refactoring bittensor/subtensor.py #1911

Merged
merged 8 commits into from
May 21, 2024
Merged

Part 1 for refactoring bittensor/subtensor.py #1911

merged 8 commits into from
May 21, 2024

Conversation

roman-opentensor
Copy link
Contributor

Since the refactoring of this module would turn into a large project, it was decided to divide it into several stages.

The current part affects everything up to the subtensor.get_transfer_fee() method

@roman-opentensor roman-opentensor requested a review from a team May 21, 2024 00:58
@roman-opentensor roman-opentensor self-assigned this May 21, 2024
@roman-opentensor roman-opentensor changed the base branch from master to staging May 21, 2024 00:59
thewhaleking
thewhaleking reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See line comments. Not necessarily requesting changes, but want to discuss these couple items first.

bittensor/subtensor.py Outdated Show resolved Hide resolved
bittensor/subtensor.py Show resolved Hide resolved
bittensor/utils/balance.py Outdated Show resolved Hide resolved
@roman-opentensor roman-opentensor merged commit 4ecdfaf into staging May 21, 2024
11 checks passed
@roman-opentensor roman-opentensor deleted the refactoring/roman/subtensor-part-1 branch May 21, 2024 19:51
This was referenced May 21, 2024
Open
Merged
roman-opentensor added a commit that referenced this pull request May 22, 2024
@roman-opentensor
Since the refactoring of this module would turn into a large project,…
525b717 
… it was decided to divide it into several stages.

This is part 2: current part affects everything up to the subtensor().tempo() method.
The "Hyper parameter calls" section was refactored by DRY.

Part 1 #1911
Part 2 #1913
@roman-opentensor roman-opentensor mentioned this pull request May 22, 2024
Merged
roman-opentensor added a commit that referenced this pull request May 23, 2024
@roman-opentensor
Since the refactoring of this module would turn into a large project,…
1f36ad1 
… it was decided to divide it into several stages.

This is part 2: current part affects everything up to the subtensor().tempo() method.
The "Hyper parameter calls" section was refactored by DRY.

Part 1 #1911
Part 2 #1913
roman-opentensor added a commit that referenced this pull request May 23, 2024
@roman-opentensor
Since the refactoring of this module would turn into a large project,…
bb1a95a 
… it was decided to divide it into several stages.

This is part 4: current part affects everything up to the subtensor().tx_rate_limit() method.
Test coverage improved.

Part 1 #1911
Part 2 #1913
Part 3 #1923
@roman-opentensor roman-opentensor mentioned this pull request May 23, 2024
Merged
@roman-opentensor roman-opentensor linked an issue May 24, 2024 that may be closed by this pull request
bittensor.subtensor module refactoring #1908
Open
3 tasks
roman-opentensor added a commit that referenced this pull request May 24, 2024
@roman-opentensor
Since the refactoring of this module would turn into a large project,…
e793bdf 
… it was decided to divide it into several stages.

This is part 5: current part affects everything in this document except of renaming class `subtensor` according to the CamelCase rule.

Test coverage improved.

Part 1 #1911
Part 2 #1913
Part 3 #1923
Part 4 #1931
@roman-opentensor roman-opentensor mentioned this pull request May 24, 2024
Merged
roman-opentensor added a commit that referenced this pull request May 24, 2024
@roman-opentensor
Since the refactoring of this module would turn into a large project,…
d9c705b 
… it was decided to divide it into several stages.

This is part 6: Renaming class 1 to comply with PEP8 and avoid namespace conflict. Refactor all references to the changed name.

Part 1 #1911
Part 2 #1913
Part 3 #1923
Part 4 #1931
Part 5 #1934
@roman-opentensor roman-opentensor mentioned this pull request May 24, 2024
Merged
roman-opentensor added a commit that referenced this pull request May 24, 2024
@roman-opentensor
Since the refactoring of this module would turn into a large project,…
735bb8f 
… it was decided to divide it into several stages.

This is part 6: Renaming class 1 to comply with PEP8 and avoid namespace conflict. Refactor all references to the changed name.

Part 1 #1911
Part 2 #1913
Part 3 #1923
Part 4 #1931
Part 5 #1934
@ibraheem-opentensor ibraheem-opentensor mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewhaleking thewhaleking thewhaleking approved these changes

@garrett-opentensor garrett-opentensor garrett-opentensor approved these changes

Assignees

@roman-opentensor roman-opentensor

Labels
async migration bittensor refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bittensor.subtensor module refactoring
3 participants
@roman-opentensor @thewhaleking @garrett-opentensor