Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change excess_data_gas and data_gas_used type from uint256 to uint64 #3392

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Change excess_data_gas and data_gas_used type from uint256 to uint64 #3392

merged 2 commits into from
Jun 1, 2023

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented May 30, 2023 •
edited
Loading

Opening a PR to track it:

@karalabe raised it on R&D Discord:

Currently the Optimism Go code uses big.Int, which doesn't make much sense
at 76M excess data gas, the price is higher than the total ether in existence

If that (gasUsed) is uint64, then imho the 4844 fields should also be changed

Note: data_gas_used field (added by #3391) should also change to uint64 if this PR gets included.

EIP update PR: ethereum/EIPs#7095

@hwwhww hwwhww added the Deneb was called: eip-4844 label May 30, 2023
@terencechain terencechain mentioned this pull request May 31, 2023
Merged
g11tech
g11tech approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

djrtwo
djrtwo approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. should make sure to test this in hive as well

(not sure the CI issues)

@StefanBratanov StefanBratanov mentioned this pull request Jun 1, 2023
Merged
2 tasks
@djrtwo djrtwo mentioned this pull request Jun 1, 2023
Closed
@hwwhww
Copy link
Contributor Author

hwwhww commented Jun 1, 2023

updated: changed data_gas_used (added by #3391) type to uint64 as well

@djrtwo djrtwo mentioned this pull request Jun 1, 2023
Merged
5 tasks
@hwwhww hwwhww merged commit 5c5c3bd into dev Jun 1, 2023
@hwwhww hwwhww deleted the excess_data_gas-type branch June 1, 2023 15:49
@james-prysm james-prysm mentioned this pull request Jun 1, 2023
Merged
@hwwhww hwwhww changed the title Change ExecutionPayload.excess_data_gas type from uint256 to uint64 Change excess_data_gas and data_gas_used type from uint256 to uint64 Jun 2, 2023
@g11tech g11tech mentioned this pull request Jun 5, 2023
Merged
7 tasks
@realbigsean realbigsean mentioned this pull request Jun 5, 2023
Closed
8 tasks
@tersec tersec mentioned this pull request Jun 8, 2023
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

@mkalinin mkalinin mkalinin approved these changes

@lightclient lightclient lightclient approved these changes

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
Deneb was called: eip-4844
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwwhww @djrtwo @mkalinin @lightclient @g11tech