block: Add data gas used and refactor cal excess data gas cal #2750
Conversation
g11tech
added
PR state: WIP
package: block
target: master
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
g11tech
added
PR state: merge ready
package: vm
package: client
and removed
PR state: WIP
labels
| const blobs = getBlobs('hello world') | ||
| const commitments = blobsToCommitments(blobs) | ||
| const versionedHashes = commitmentsToVersionedHashes(commitments) | ||
| const proofs = blobsToProofs(blobs, commitments) |
There was a problem hiding this comment.
Do you think it would be worthwhile creating a generic test utility method for creating blob transactions (like here but more generic)? Or maybe we update the static constructor to let you pass in the data for one or more blobs and it generates all of it? It's just a lot of boilerplate to create these blob transactions (the more I think about it).
There was a problem hiding this comment.
yes thats a very good idea to have a static method in the tx OR
we can modify fromTxData to just accept blobs string[] and just generate the rest?
There was a problem hiding this comment.
yes thats a very good idea to have a static method in the tx OR we can modify fromTxData to just accept blobs string[] and just generate the rest?
Yup, that's more or less what I was thinking. Let's tackle as a separate PR though. Not crucial for this one.
g11tech
force-pushed
the
4844-add-datagasused
branch
from
bcf6441
to
92b6277
Compare
|
Great PR overall! 😃🎉❤️ |
Implements
data_gas_usedto header ethereum/EIPs#7062excess_data_gasto 64 bit ethereum/EIPs#7095as part of devnet 6 target spec