Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4844: reduce size of excess_data_gas to 64 bit #7095

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

lightclient
Copy link
Member

It seems like an oversight on my part in #5353 to make excess_blobs a 256 bit unsigned integer and it has propagated through the various changes until now. @karalabe noticed that excess_data_gas will never even need more than a 64 bit unsigned integer. After 1500 blocks, the data fee ends up being around 2**256, which is obviously much larger than could possibly be paid. log2(1500*(MAX_DATA_GAS_PER_BLOCK - TARGET_DATA_GAS_PER_BLOCK)) = 28.5, so 64 bit is fine.

@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels May 30, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 30, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title 4844: reduce size of excess_data_gas to 64 bit Update EIP-4844: reduce size of excess_data_gas to 64 bit May 30, 2023
yperbasis
yperbasis previously approved these changes May 30, 2023
g11tech
g11tech previously approved these changes May 31, 2023
@lightclient
Copy link
Member Author

Approved in CL call 110

@lightclient lightclient marked this pull request as ready for review June 2, 2023 15:42
@lightclient lightclient requested a review from eth-bot as a code owner June 2, 2023 15:42
@lightclient lightclient closed this Jun 2, 2023
@lightclient lightclient reopened this Jun 2, 2023
@eth-bot eth-bot enabled auto-merge (squash) June 2, 2023 15:42
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants