Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/4844: excessDataGas and dataGasUsed spec update #139

Merged
merged 21 commits into from
Jun 14, 2023

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jun 8, 2023

Addresses the following spec changes:

@marioevz marioevz marked this pull request as ready for review June 13, 2023 19:24
@marioevz marioevz force-pushed the excess-data-gas-calc-spec-update branch from d8f7c2d to 419a0bb Compare June 14, 2023 22:16
@marioevz marioevz changed the title fillers/4844: excessDataGas and dataGasUsed spec update tests/4844: excessDataGas and dataGasUsed spec update Jun 14, 2023
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utils file is well used :D

I will re-review after you have re-based onto Dan changes

tests/eips/eip4844/test_excess_data_gas.py Outdated Show resolved Hide resolved
@marioevz marioevz force-pushed the excess-data-gas-calc-spec-update branch from 419a0bb to 18b555a Compare June 14, 2023 23:18
@marioevz
Copy link
Member Author

@spencer-tb rebased and fixed the comment 👍

@spencer-tb spencer-tb merged commit 5ac602e into ethereum:main Jun 14, 2023
@marioevz marioevz deleted the excess-data-gas-calc-spec-update branch June 14, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants