Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data_gas_used field to ExecutionPayload #3391

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Add data_gas_used field to ExecutionPayload #3391

merged 3 commits into from
Jun 1, 2023

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented May 29, 2023

Due to the recent EIP-4844 update: ethereum/EIPs#7062, the CL side also has to add data_gas_used field to ExecutionPayload.

I intentionally didn't update EIP6110 light client specs because they are expected to be deleted in #3389.

@djrtwo
In the EIP-4844 call today (ethereum/pm#782) we tend to agree to include this change to devnet-6. That means we'd better publish a new spec release this week. :rage1:

@hwwhww hwwhww added the Deneb was called: eip-4844 label May 29, 2023
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably have a couple of tests with some non-zero execution payload values just to ensure encodings can be handled fine.

Maybe a test with all values in EL payload as MAX and another as all random

@lightclient
Copy link
Member

This has been merged into the EIP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deneb was called: eip-4844
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants