Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionPayload Add data_gas_used and change type of excess_data_gas #7215

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Jun 1, 2023

PR Description

Upgraded reference tests to v1.4.0-alpha.1 https://github.com/ethereum/consensus-specs/releases/tag/v1.4.0-alpha.1

Implements ethereum/consensus-specs#3392 and ethereum/consensus-specs#3391 required for Devnet 6

  • Had to change the expected BlobSidecar signature in LocalSignerTest because the block root has been changed because of the additional field and the changed type

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov changed the title Add data gas used and change excess data gas type Execution Payload Add data_gas_used and change type of excess_data_gas Jun 1, 2023
@StefanBratanov StefanBratanov changed the title Execution Payload Add data_gas_used and change type of excess_data_gas ExecutionPayload Add data_gas_used and change type of excess_data_gas Jun 1, 2023
@StefanBratanov StefanBratanov marked this pull request as draft June 1, 2023 15:38
@StefanBratanov StefanBratanov force-pushed the add_data_gas_used_and_change_excess_data_gas_type branch from 2459d53 to 4cef5c8 Compare June 2, 2023 10:07
@StefanBratanov StefanBratanov force-pushed the add_data_gas_used_and_change_excess_data_gas_type branch from fd69939 to 0252503 Compare June 2, 2023 15:56
@StefanBratanov StefanBratanov marked this pull request as ready for review June 2, 2023 15:58
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) June 5, 2023 09:17
@StefanBratanov StefanBratanov merged commit 0f6ebe3 into Consensys:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants