Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tree-shake ability of all modules #1472

Merged
merged 13 commits into from
Aug 9, 2022
Merged

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Jul 26, 2022

Export subscription specific stuff via graphql-yoga/subscription and schema specific stuff via graphql-yoga/schema.

TODO:


Closes #1449
Related #1305
Closes #1305
Closes #1350

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2022

⚠️ No Changeset found

Latest commit: cd9679f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@n1ru4l n1ru4l changed the base branch from master to feat-single-package July 26, 2022 08:59
@github-actions
Copy link
Contributor

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@graphql-yoga/common@3.0.0-canary-c29b354.0
graphql-yoga@3.0.0-canary-c29b354.0
@graphql-yoga/node@3.0.0-canary-c29b354.0
@graphql-yoga/render-graphiql@3.0.0-canary-c29b354.0

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

❌ Benchmark Failed

Failed assertions detected

If the performance regression is expected, please increase the failing threshold.

     ✗ no_errors
      ↳  0% — ✓ 0 / ✗ 69581
     ✗ expected_result
      ↳  0% — ✓ 0 / ✗ 69581

     checks.....................: 0.00%   ✓ 0           ✗ 139162
     data_received..............: 18 MB   608 kB/s
     data_sent..................: 8.0 MB  267 kB/s
     http_req_blocked...........: avg=1.34µs   min=800ns   med=1.2µs    max=289.6µs p(90)=1.7µs    p(95)=2.2µs   
     http_req_connecting........: avg=1ns      min=0s      med=0s       max=131.6µs p(90)=0s       p(95)=0s      
   ✓ http_req_duration..........: avg=349.3µs  min=254.3µs med=320.9µs  max=18.39ms p(90)=381.5µs  p(95)=428.71µs
     http_req_failed............: 100.00% ✓ 69581       ✗ 0     
     http_req_receiving.........: avg=21.47µs  min=11.5µs  med=19.4µs   max=6.87ms  p(90)=26.4µs   p(95)=28.7µs  
     http_req_sending...........: avg=8.02µs   min=4.4µs   med=5.8µs    max=1.06ms  p(90)=11.4µs   p(95)=12.3µs  
     http_req_tls_handshaking...: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...........: avg=319.8µs  min=232.6µs med=293.1µs  max=18.08ms p(90)=347.5µs  p(95)=395.21µs
     http_reqs..................: 69581   2319.246676/s
     iteration_duration.........: avg=424.08µs min=308.3µs med=394.41µs max=18.82ms p(90)=468.11µs p(95)=516.61µs
     iterations.................: 69581   2319.246676/s
     vus........................: 0       min=0         max=1   
     vus_max....................: 1       min=1         max=1   

Base automatically changed from feat-single-package to v3 July 26, 2022 09:31
@n1ru4l n1ru4l force-pushed the feat-schema-subscription-export branch from 601032a to 779a6f6 Compare July 26, 2022 09:34
@n1ru4l
Copy link
Collaborator Author

n1ru4l commented Jul 26, 2022

@ardatan What kind of status/message should we use if there is no GraphQLSchema provided?

@ardatan
Copy link
Collaborator

ardatan commented Jul 26, 2022

image
I still get an error for this. Do you have any idea why?

@n1ru4l
Copy link
Collaborator Author

n1ru4l commented Jul 26, 2022

@ardatan No works fone for me, maybe restart VSCode and/or TypeScript

@n1ru4l n1ru4l merged commit 9ca0def into v3 Aug 9, 2022
@n1ru4l n1ru4l deleted the feat-schema-subscription-export branch August 9, 2022 11:00
This was referenced Sep 21, 2022
@saihaj saihaj mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants