Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Masking for Yoga hooks & Respect result processor in case of an error #1521

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Jul 30, 2022

No description provided.

@ardatan ardatan requested a review from n1ru4l July 30, 2022 12:57
@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2022

⚠️ No Changeset found

Latest commit: 057f320

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 173842      ✗ 0    
     data_received..................: 23 MB   771 kB/s
     data_sent......................: 10 MB   333 kB/s
     http_req_blocked...............: avg=1.34µs   min=800ns   med=1.1µs   max=429.5µs p(90)=1.6µs   p(95)=2µs    
     http_req_connecting............: avg=1ns      min=0s      med=0s      max=119.9µs p(90)=0s      p(95)=0s     
   ✓ http_req_duration..............: avg=262.86µs min=177µs   med=237.5µs max=18.9ms  p(90)=301.1µs p(95)=330.5µs
       { expected_response:true }...: avg=262.86µs min=177µs   med=237.5µs max=18.9ms  p(90)=301.1µs p(95)=330.5µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 86921
     http_req_receiving.............: avg=20.59µs  min=10.9µs  med=19µs    max=13.59ms p(90)=25.3µs  p(95)=27.5µs 
     http_req_sending...............: avg=9.18µs   min=4.3µs   med=6.7µs   max=5.78ms  p(90)=11.6µs  p(95)=13.1µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=233.08µs min=156.3µs med=209.6µs max=18.73ms p(90)=268.1µs p(95)=295.5µs
     http_reqs......................: 86921   2897.155193/s
     iteration_duration.............: avg=338.53µs min=234.2µs med=309.1µs max=19.45ms p(90)=386.4µs p(95)=423.2µs
     iterations.....................: 86921   2897.155193/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@ardatan ardatan changed the base branch from respect-accept-headers to respect-result-processor July 30, 2022 13:12
@ardatan ardatan changed the base branch from respect-result-processor to respect-accept-headers July 30, 2022 13:52
@ardatan ardatan changed the base branch from respect-accept-headers to respect-result-processor July 30, 2022 13:52
@ardatan ardatan changed the title Error Masking for Yoga hooks Error Masking for Yoga hooks & Respect result processor in case of an error Jul 30, 2022
@ardatan ardatan changed the base branch from respect-result-processor to respect-accept-headers July 30, 2022 13:53
@github-actions
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • you somehow changed the formatting of one file (try run prettier)
  • empty extensions {} should be omitted from the payload IMHO

@ardatan ardatan merged commit e021c6f into v3 Aug 1, 2022
@ardatan ardatan deleted the error-masking-http branch August 1, 2022 09:13
@ardatan ardatan self-assigned this Aug 2, 2022
@theguild-bot theguild-bot mentioned this pull request Aug 9, 2022
This was referenced Sep 21, 2022
@saihaj saihaj mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants