Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared eslint setup #1902

Merged
merged 5 commits into from
Oct 19, 2022
Merged

shared eslint setup #1902

merged 5 commits into from
Oct 19, 2022

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Oct 17, 2022 •
edited
Loading

closes #1894

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1a1273c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saihaj saihaj changed the base branch from v2 to v3 October 17, 2022 16:47
@saihaj saihaj self-assigned this Oct 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022 •
edited
Loading

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 1.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 1.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/common 3.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/redis-event-target 1.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/typed-event-target 1.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/graphiql 3.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
graphql-yoga 3.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎
@graphql-yoga/subscription 3.0.0-alpha-20221017184800-e477275f npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022 •
edited
Loading

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 158138      ✗ 0    
     data_received..................: 24 MB   785 kB/s
     data_sent......................: 9.1 MB  303 kB/s
     http_req_blocked...............: avg=1.33µs   min=800ns   med=1.2µs   max=1.51ms  p(90)=1.6µs   p(95)=2.1µs  
     http_req_connecting............: avg=17ns     min=0s      med=0s      max=1.34ms  p(90)=0s      p(95)=0s     
   ✓ http_req_duration..............: avg=295.72µs min=195.3µs med=266.3µs max=17.99ms p(90)=333.6µs p(95)=356.8µs
       { expected_response:true }...: avg=295.72µs min=195.3µs med=266.3µs max=17.99ms p(90)=333.6µs p(95)=356.8µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 79069
     http_req_receiving.............: avg=21.2µs   min=11.4µs  med=19.09µs max=6.17ms  p(90)=26µs    p(95)=29µs   
     http_req_sending...............: avg=9.18µs   min=4.2µs   med=6.9µs   max=4.04ms  p(90)=11.7µs  p(95)=12.7µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=265.33µs min=174.8µs med=238.4µs max=17.85ms p(90)=299.6µs p(95)=320.8µs
     http_reqs......................: 79069   2635.511781/s
     iteration_duration.............: avg=372.42µs min=253.6µs med=340.6µs max=19.77ms p(90)=420.5µs p(95)=449.2µs
     iterations.....................: 79069   2635.511781/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1

dimaMachina
dimaMachina reviewed Oct 17, 2022
View reviewed changes
examples/apollo-federation/gateway/gateway.js
@@ -1,3 +1,4 @@
/* eslint-disable */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can still lint examples, to avoid future errors, some things we can explicitly ignores like eslint-disable-next-line or eslint-disable-line but not full file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these node examples it was complaining a lot about require not defined and do not use require so I decide to disable linting on full example

Copy link
Collaborator

@dimaMachina dimaMachina Oct 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to replace require with importing examples? Since node 12 is deprecated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn’t we need to be on node 16+ for that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 16 is good!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022 •
edited
Loading

🚀 Website Preview

The latest changes to the website are available as preview in: https://2edfa997.graphql-yoga.pages.dev

dimaMachina
dimaMachina reviewed Oct 18, 2022
View reviewed changes
website/src/pages/_app.tsx

export default function App({ Component, pageProps }: AppProps) {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
export default function App({ Component, pageProps }: any) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pnpm should fix types issues (:

@ardatan ardatan merged commit c36ef7a into v3 Oct 19, 2022
@ardatan ardatan deleted the saihaj/eslint branch October 19, 2022 08:07
@saihaj saihaj mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaMachina dimaMachina dimaMachina left review comments

@dotansimha dotansimha dotansimha approved these changes

@ardatan ardatan Awaiting requested review from ardatan

@enisdenjo enisdenjo Awaiting requested review from enisdenjo

Assignees

@saihaj saihaj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saihaj @dotansimha @dimaMachina @ardatan