-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make graphql-tools dependencies tree-shakable #1305
Milestone
Comments
Closed
We decided upon, that we re-export the functionality under |
1 task
Unfortunately, because of ESM and TypeScript limitations, we cannot simply provide deep imports. Instead, we can mark all our files as side-effect free, which allows tree-shaking. |
n1ru4l
changed the title
Remove graphql-tools dependencies
Make graphql-tools dependencies tree-shakable
Aug 2, 2022
@n1ru4l I think we can close this, no? |
yas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@graphql-tools/utils
and@graphql-tools/schema
dependency fromgraphql-yoga
as it makes up quite a big chunk of the whole bundle. (https://bundlephobia.com/package/@graphql-yoga/common@2.8.3).@graphql-tools/schema
functionality for constructing a schema is part ofgraphql-js
.makeExecutableSchema
even if user passes their own schema@graphql-yoga/common/schema
? ✅makeExecutableSchema
from yoga in a tree shakable way and removemakeExecutableSchema
fromcreateServer
so by defaultcreateServer
would take less bundle size andmakeExecutableSchema
would be tree shaken/gone.makeExecutableSchema
or some other schema factory lib.graphql-js
versions@graphql-tools/utils
The text was updated successfully, but these errors were encountered: