Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make @graphql-yoga/subscriptions export tree-shakable #1350

Closed
Tracked by #1358
Urigo opened this issue Jul 6, 2022 · 2 comments
Closed
Tracked by #1358

Make @graphql-yoga/subscriptions export tree-shakable #1350

Urigo opened this issue Jul 6, 2022 · 2 comments
Assignees
@n1ru4l
Milestone
v3

Comments

@Urigo
Copy link
Collaborator

Urigo commented Jul 6, 2022

  1. Inline the stuff into the @graphql-yoga/common package
  2. Export it as @graphql-yoga/common/subscriptions
@Urigo Urigo added this to the v3 milestone Jul 6, 2022
@theguild-bot theguild-bot mentioned this issue Jul 6, 2022
Closed
@n1ru4l n1ru4l self-assigned this Jul 18, 2022
@n1ru4l n1ru4l changed the title Stop @graphql-yoga/subscriptions re-exporting from @graphql-yoga/common Make @graphql-yoga/subscriptions export tree-shakable Aug 2, 2022
@n1ru4l
Copy link
Collaborator

n1ru4l commented Aug 2, 2022

Renamed this issue because of #1305 (comment)

@n1ru4l n1ru4l mentioned this issue Aug 4, 2022
Merged
1 task
@n1ru4l
Copy link
Collaborator

n1ru4l commented Aug 15, 2022

closed via #1472

@n1ru4l n1ru4l closed this as completed Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n1ru4l n1ru4l

Labels
None yet
Projects
None yet
Milestone
v3
Development

No branches or pull requests
2 participants
@Urigo @n1ru4l