Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Test clang-tidy --checks performance-faster-string-find #29926

Closed

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 21, 2020

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

ERROR: Build errors found during clang-tidy run.

DQM/CSCMonitorModule/plugins/CSCDQM_Collection.cc:291:27: error: expected expression [clang-diagnostic-error]
        while (label.find(''') != std::string::npos) {
                          ^
Suppressed 1214 warnings (1208 in non-user code, 6 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@mommsen
Copy link
Contributor

mommsen commented May 28, 2020

+1

@santocch
Copy link

+1

@mrodozov
Copy link
Contributor

-note
keep it

@Martin-Grunewald
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment