-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang tidy checks - add new checks to .clang-tidy #30665
Conversation
The code-checks are being triggered in jenkins. |
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: .clang-tidy @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Was it this PR #30505 after which we agreed to enable the new checks? |
Hi @smuzaffar , @makortel, @mrodozov , #30505 needs to be updated (there is a conflict to be solved). Can we merge this PR ? |
@silviodonato In short, yes I'm in favor to merge it, tldr: |
@smuzaffar , @makortel we agreed to merge this PR, didn't we? |
+core |
The tests are being triggered in jenkins.
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
PR description:
Adds the new checks to be applied on every PR.
To be merged after #30632
PR validation:
Applied on cmssw, with few exceptions (that are fixed) it builds