[RFC] Test clang-tidy --checks performance-inefficient-algorithm

[fwyzard]

See the description at https://clang.llvm.org/extra/clang-tidy/checks/performance-inefficient-algorithm.html .

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29929/15544

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File .clang-tidy modified in PR(s): Enable additional code checks #29858, [RFC] Test clang-tidy --checks performance-implicit-conversion-in-loop #29928, [RFC] Test clang-tidy --checks performance-for-range-copy #29927, [RFC] Test clang-tidy --checks performance-faster-string-find #29926
  • File CondFormats/HcalObjects/src/HBHEDarkening.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-implicit-conversion-in-loop #29928, [RFC] Test clang-tidy --checks performance-for-range-copy #29927, [RFC] Test clang-tidy --checks performance-faster-string-find #29926
  • File Fireworks/Core/src/FWDialogBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-implicit-conversion-in-loop #29928, [RFC] Test clang-tidy --checks performance-for-range-copy #29927, [RFC] Test clang-tidy --checks performance-faster-string-find #29926

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

.clang-tidy
CondFormats/HcalObjects
Fireworks/Core

@smuzaffar, @Dr15Jones, @makortel, @christopheralanwest, @tocheng, @cmsbuild, @alja, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @tocheng, @alja, @mmusich, @abdoulline, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

does the same thing as #29928?

[fwyzard]

Actually, I think both this and #29928 do not flag anything new: these changes should already be flagged by the existing checks.

[alja]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6480/console Started: 2020/05/21 16:59

[cmsbuild]

+1
Tested at: 158823d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69c974/6480/summary.html
CMSSW: CMSSW_11_1_X_2020-05-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69c974/6480/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694416
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[pohsun]

+1

[ggovi]

+1

[mrodozov]

• note
  keep it