Test clang-tidy --checks performance-inefficient-algorithm

cms-sw · May 21, 2020 · 158823d · 158823d
1 parent 407df30
commit 158823d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -9,6 +9,7 @@ Checks: -*,
   ,modernize-use-equals-delete,
   ,modernize-use-nullptr,
   ,modernize-use-override,
+  ,performance-inefficient-algorithm,
   ,performance-unnecessary-copy-initialization,
   ,readability-container-size-empty,
   ,readability-redundant-string-cstr,

diff --git a/CondFormats/HcalObjects/src/HBHEDarkening.cc b/CondFormats/HcalObjects/src/HBHEDarkening.cc
@@ -105,7 +105,7 @@ float HBHEDarkening::degradation(float intlumi, int ieta, int lay) const {
   //accumulate degradation over years
   float response = 1.0;
   std::string yearForLumi = getYearForLumi(intlumi);
-  assert(yearForLumi.size());
+  assert(!yearForLumi.empty());
 
   for (const auto& year : years_) {
     response *= degradationYear(year, intlumi, ieta, lay);

diff --git a/Fireworks/Core/src/FWDialogBuilder.cc b/Fireworks/Core/src/FWDialogBuilder.cc
@@ -51,7 +51,7 @@ FWLayoutBuilder &FWLayoutBuilder::indent(int left /*= 2*/, int right /* = -1*/)
 
 /** Return the last vertical frame, for more control on the layout. */
 TGVerticalFrame *FWLayoutBuilder::verticalFrame(void) {
-  assert(m_framesStack.size());
+  assert(!m_framesStack.empty());
   return m_framesStack.back();
 }