Clang tidy checks - fix clang warnings #30632

mrodozov · 2020-07-10T10:49:43Z

PR description:

Fixes the last failures when the checks in #30508 were applied.
The checks created const refs with the original types which resulted in clang warnings:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc4bbb/7669/clang-new-warnings.log

PR validation:

Builds, clang checks and format passes

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild · 2020-07-10T10:50:06Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-10T10:56:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30632/16901

This PR adds an extra 100KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/OfflineValidation/bin/DMRtrends.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks performance-inefficient-vector-operation #29930, [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File Alignment/OfflineValidation/plugins/PrimaryVertexValidation.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Alignment/OfflineValidation/plugins/TrackerOfflineValidation.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File CalibTracker/SiStripCommon/plugins/PrescaleEventFilter.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File CalibTracker/SiStripCommon/plugins/ShallowRechitClustersProducer.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File CalibTracker/SiStripCommon/plugins/ShallowSimhitClustersProducer.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File CalibTracker/SiStripCommon/plugins/ShallowTree.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File HLTriggerOffline/Egamma/src/EmDQM.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File HLTriggerOffline/Egamma/src/EmDQMReco.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File L1TriggerConfig/Utilities/src/L1MenuViewer.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File L1TriggerConfig/Utilities/src/L1TMuonBarrelParamsViewer.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File L1TriggerConfig/Utilities/src/L1TriggerKeyExtViewer.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-faster-string-find #29926

cmsbuild · 2020-07-10T10:56:51Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

Alignment/OfflineValidation
CalibTracker/SiStripCommon
HLTriggerOffline/Egamma
L1TriggerConfig/Utilities

@benkrikler, @kmaeshima, @christopheralanwest, @schneiml, @andrius-k, @tocheng, @cmsbuild, @rekovic, @jfernan2, @fioriNTU, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@echabert, @adewit, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @Martin-Grunewald, @missirol, @mverzett, @tlampen, @mschrode, @mmusich, @mtosi this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

mrodozov · 2020-07-10T11:19:45Z

please test

cmsbuild · 2020-07-10T11:20:09Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-09-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7855/console Started: 2020/07/10 14:57

cmsbuild · 2020-07-10T14:41:29Z

+1
Tested at: 5d140cc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e1c89/7855/summary.html
CMSSW: CMSSW_11_2_X_2020-07-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-10T14:41:31Z

Comparison job queued.

cmsbuild · 2020-07-10T17:25:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e1c89/7855/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2787429
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2787372
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

jfernan2 · 2020-07-10T18:45:45Z

+1

pohsun · 2020-07-11T02:39:00Z

+1

cmsbuild · 2020-07-24T10:22:29Z

The code-checks are being triggered in jenkins.

silviodonato · 2020-07-24T10:23:20Z

@mrodozov I solved a conflict, please double check 7b6ce55 . Thank you
@rekovic

silviodonato · 2020-07-24T10:24:46Z

please test

cmsbuild · 2020-07-24T10:28:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30632/17285

This PR adds an extra 104KB to repository

cmsbuild · 2020-07-24T10:28:51Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8267/console Started: 2020/07/24 12:49

cmsbuild · 2020-07-24T10:28:52Z

Pull request #30632 was updated. @benkrikler, @kmaeshima, @christopheralanwest, @schneiml, @andrius-k, @tocheng, @cmsbuild, @rekovic, @jfernan2, @fioriNTU, @tlampen, @pohsun can you please check and sign again.

mrodozov · 2020-07-24T11:22:04Z

@silviodonato I see redundant headers removed, should be fine

cmsbuild · 2020-07-24T12:57:43Z

+1
Tested at: 7b6ce55
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e1c89/8267/summary.html
CMSSW: CMSSW_11_2_X_2020-07-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Fix for Conddb function to identify current run #30739 @ggovi: Fix for Conddb function to identify current run
Move to std::filesystem on Calibration/EcalCalibAlgos #30831 @camolezi: Move to std::filesystem on Calibration/EcalCalibAlgos
Update PPS records for 2018 and Run-3 #30890 @christopheralanwest: Update PPS records for 2018 and Run-3
remove obsolete CINT ifdef as it is no longer needed #30869 @davidlange6: remove obsolete CINT ifdef as it is no longer needed
Migrate PAT DataFormats from boost::format to {fmt} #30861 @fwyzard: Migrate PAT DataFormats from boost::format to {fmt}

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e1c89/8267/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e1c89/8267/git-merge-result

cmsbuild · 2020-07-24T12:57:46Z

Comparison job queued.

cmsbuild · 2020-07-24T14:20:20Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e1c89/8267/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2526188
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2526140
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

silviodonato · 2020-07-25T07:13:04Z

merge

jfernan2 · 2020-07-28T14:10:34Z

+1
For the records

Clang tidy checks - fix clang warnings

5d140cc

cmsbuild added this to the CMSSW_11_2_X milestone Jul 10, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels Jul 10, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 10, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 10, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 10, 2020

cmsbuild added dqm-approved and removed dqm-pending labels Jul 10, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending dqm-pending tests-pending labels Jul 24, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 24, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 24, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 24, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 25, 2020

cmsbuild merged commit 0082979 into cms-sw:master Jul 25, 2020

cmsbuild added dqm-approved and removed dqm-pending labels Jul 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clang tidy checks - fix clang warnings #30632

Clang tidy checks - fix clang warnings #30632

mrodozov commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

mrodozov commented Jul 10, 2020

cmsbuild commented Jul 10, 2020 •

edited

Loading

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

jfernan2 commented Jul 10, 2020

pohsun commented Jul 11, 2020

cmsbuild commented Jul 24, 2020

silviodonato commented Jul 24, 2020

silviodonato commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020 •

edited

Loading

cmsbuild commented Jul 24, 2020

mrodozov commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

silviodonato commented Jul 25, 2020

jfernan2 commented Jul 28, 2020

Clang tidy checks - fix clang warnings #30632

Clang tidy checks - fix clang warnings #30632

Conversation

mrodozov commented Jul 10, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

mrodozov commented Jul 10, 2020

cmsbuild commented Jul 10, 2020 • edited Loading

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

jfernan2 commented Jul 10, 2020

pohsun commented Jul 11, 2020

cmsbuild commented Jul 24, 2020

silviodonato commented Jul 24, 2020

silviodonato commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020 • edited Loading

cmsbuild commented Jul 24, 2020

mrodozov commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

silviodonato commented Jul 25, 2020

jfernan2 commented Jul 28, 2020

cmsbuild commented Jul 10, 2020 •

edited

Loading

cmsbuild commented Jul 24, 2020 •

edited

Loading