Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost filesystem in EventFilter/Utilities #30602

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

camolezi
Copy link
Contributor

@camolezi camolezi commented Jul 8, 2020

PR description:

Changed boost filesystem for standard template library filesystem.
The code should have the same behaviour.

PR validation:

Passed on basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

-code-checks

ERROR: Build errors found during clang-tidy run.

gmake: *** [tmp/slc7_amd64_gcc820/Makefile:32: .SCRAM/slc7_amd64_gcc820/timestamps/cmsswdata] Error 1
You are trying to build/setup tools for SCRAM_ARCH slc7_amd64_gcc820.
while your project area is currently setup for following SCRAM_ARCH(s):
	slc7_amd64_gcc820
--
gmake: *** [tmp/slc7_amd64_gcc820/Makefile:32: .SCRAM/slc7_amd64_gcc820/timestamps/coral] Error 1
Updating symlinks under external/slc7_amd64_gcc820

Finding a value for CLHEPHEADER_BASE:
--
gmake: *** No rule to make target 'code-checks'.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@davidlange6
Copy link
Contributor

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30602/16862

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

DQMServices/FileIO
EventFilter/Utilities

@perrotta, @andrius-k, @kmaeshima, @emeschi, @schneiml, @cmsbuild, @mommsen, @jfernan2, @fioriNTU, @slava77, @jpata can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @barvic this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

+1
Tested at: 782b6e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1afa4b/7793/summary.html
CMSSW: CMSSW_11_2_X_2020-07-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison job queued.

@mommsen
Copy link
Contributor

mommsen commented Jul 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1afa4b/7793/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787364
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787313
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 9, 2020

+1

@slava77
Copy link
Contributor

slava77 commented Jul 9, 2020

+1

for #30602 782b6e8

  • technical; mostly changing in the parts of EventFilter/Utilities in daq (not reco) purview

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ca4ee8a into cms-sw:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants