Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added QTest support to Protobuf files in DQMFileSaverPB #30357

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

andrius-k
Copy link

PR description:

Adds QTest information to protocol buffer files saved with DQMFileSaverPB.

PR validation:

PR was validated locally.

@andrius-k
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30357/16387

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@andrius-k
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30357/16390

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andrius-k (Andrius) for master.

It involves the following packages:

DQMServices/FileIO

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: ad7843b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d88b0b/7317/summary.html
CMSSW: CMSSW_11_2_X_2020-06-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d88b0b/7317/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778915
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778864
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

what's the status/plan of this PR?
@andrius-k @jfernan2 @kmaeshima @fioriNTU @schneiml

@andrius-k
Copy link
Author

andrius-k commented Jul 10, 2020

Hi Silvio @silviodonato,
This PR is related to the new DQM GUI that is in the works. It can be merged on its own without waiting for the work on the new DQM GUI to be completed. I will fix the for loop that you pointed out in the coming days.

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 9b72a77 into cms-sw:master Jul 14, 2020
@andrius-k
Copy link
Author

+1
Signing for the sake of completeness.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants