-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added QTest support to Protobuf files in DQMFileSaverPB #30357
Added QTest support to Protobuf files in DQMFileSaverPB #30357
Conversation
please test |
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30357/16387
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30357/16390
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @andrius-k (Andrius) for master. It involves the following packages: DQMServices/FileIO @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
what's the status/plan of this PR? |
Hi Silvio @silviodonato, |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Adds QTest information to protocol buffer files saved with DQMFileSaverPB.
PR validation:
PR was validated locally.