[pull] staging from joomla:staging #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://github.com/avatars/in/12910?s=60&v=4){kind=small}
Chosen is not accessible so we shouldnt use it unless it offers something useful. In the search component in the front end there are potentially two lists Ordering and display # Neither of these require or benefit from chosen so this simple PR returns them to regular and accessible lists
The $key parameter can be either an array or a string but from PHPDoc it was only an array
* Improvements to mediamanager.js and popup-imagemanager.js - use jquery's prop function instead of attr - properly and consistently encode and decode URI components - explicitly use global variables from the global scope * Wait till the iframe is loaded before doing things that required the iframe to be loaded.
…25406) Pinned sodium_compat because of file case change, atm this could not be handled by the Joomla! updater.
* Use correct language strings * Fix unknown column * Fix sort header * Assign column * Update administrator/components/com_fields/models/fields.php Co-Authored-By: SharkyKZ <sharkykz@gmail.com> * Fix language column * Fix language column * Fix language column
…x for the similar tags module: 0416160
* Render values in profile * Remove blank line Co-Authored-By: Quy <quy@fluxbb.org> Co-authored-by: Quy <quy@fluxbb.org>
* Show correct message when file is too large * Move media helper * Typo Co-Authored-By: Quy <quy@fluxbb.org> * Case insensitive comparison for filter * Typo in comment Co-Authored-By: Quy <quy@fluxbb.org> Co-authored-by: Robert Deutz <rdeutz@googlemail.com>
* Update folderlist.php * Update folderlist.php Return if (!is_dir($path) && !is_dir(JPATH_ROOT . '/' . $path)) Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Robert Deutz <rdeutz@googlemail.com>
I deleted a line that I don't think we need
#27744 allow showing ucm_content items with core_access=0. Similar fi…
Remove all default values for type 'text' or 'mediumtext' - redo of PR #17860
* mysql * postgresql * mssql
…ld (#27561) * Do not ignore subform filter * Do not foreach empty value Co-authored-by: Robert Deutz <rdeutz@googlemail.com>
* Fix submitting forms with empty repeatable subforms * Use the validation rule
…inks (#28055) * Add new "sponsored" and "ugc" options to rel attribute for external links Pull Request for #26312 ###Why https://support.google.com/webmasters/answer/96569?hl=en Advanced users (copywriters, bloggers, etc.) are very concerned about SEO. Their projects often live thanks to affiliation, sponsorship and advertising. It is important to provide them with all the tools necessary for a correct supply of information to the search engine, so as not to be penalized and to constantly improve aspects such as indexing and positioning. These two options specifically help Google identify the behavior of outbound links from Joomla sites, thus providing correct information on what to expect from the connected external source. ### Summary of Changes Add new "sponsored" and "ugc" options to rel attribute of external URL menu type. ### Testing Instructions Add new menu item Select System Links > URL Click **Link Type** tab Click **Link Rel Attribute** dropdown See **spondored** and **ugc** option ### Next Step (not in this PR) Users should select more than one option for "rel" attribute. https://www.w3.org/TR/html401/struct/links.html#adef-rel > rel = link-types [CI] > This attribute describes the relationship from the current document to the anchor specified by the href attribute. > The value of this attribute is a space-separated list of link types. * Alphabetical order for new rel options
brianteeman
added a commit
that referenced
this pull request
May 26, 2020
really minor but best to fix it before quy picks up on it ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )