Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submitting forms with empty repeatable subforms #27999

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Fix submitting forms with empty repeatable subforms #27999

merged 2 commits into from
Feb 24, 2020

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Feb 21, 2020

Summary of Changes

Fixes a regression not allowing to submit forms containing repeatable subforms without any rows added.

Testing Instructions

Try to save Users component or System - Redirect plugin configuration.

Expected result

Form is saved.

Actual result

Validation errors:

Field required: Domain Name
Field required: Term

Documentation Changes Required

No.

@Quy
Copy link
Contributor

Quy commented Feb 21, 2020

I have tested this item ✅ successfully on 59fed21


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27999.

1 similar comment
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 59fed21


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27999.

@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27999.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 21, 2020
@HLeithner HLeithner merged commit bd13b49 into joomla:staging Feb 24, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 24, 2020
@HLeithner HLeithner added this to the Joomla! 3.9.16 milestone Feb 24, 2020
@SharkyKZ SharkyKZ deleted the patch-3 branch February 24, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants