-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move editAssociations code to regular save method #27941
Conversation
@sanek4life Please thest. I'll test too tomorrow. |
I have tested this item ✅ successfully on e89d1f5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27941. |
I have tested this item ✅ successfully on e89d1f5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27941. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27941. |
Thanks @Bakual |
Already merged. ;) Will be available in next release 3.9.16. |
What to do with other |
Yep, unfortunately there is no other way as the data is lost. Thanks for being stubborn with this issue. It was quite a bit hidden 😄 |
@Bakual |
Issue open #28310 |
Pull Request for Issue #27921
Summary of Changes
The associations button in the article edit form triggered the
editAssocations
task. That task invoked a save method in the model and then redirected to the association manager.Unfortunately that save method bypassed everything done in the controller->save method. Resulting beside other potential issues in the issue above where the dateformat wasn't properly translated back.
This PR moves the code from the editAssociations method to the save method with a conditional on the active task.
in the controller, the "editAssociations" task is registered as a variant of the save method.
I have left the old "editAssociations" methods in the controller and model to keep B/C and added a deprecation note for 5.0.
Testing Instructions
Expected result
Date is still there
Actual result
Date is empty
Documentation Changes Required
None